-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Explore using sqlite #652
Draft
Hinton
wants to merge
12
commits into
main
Choose a base branch
from
ps/sqlite
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Explore using sqlite #652
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
21e6143
Explore using sqlite
Hinton 87a736d
Wire up repository to sync
Hinton 9423eb6
Merge branch 'main' of github.com:bitwarden/sdk into ps/sqlite
Hinton 04dd9ff
Refactor interface into vault module
Hinton 41ed412
Improve error handling
Hinton e447bbb
Resolve linting and remove an expect
Hinton ea9f4e1
Create a DB Migrator
Hinton 9e2d3a2
Clean up migrator
Hinton 99cb6ac
Use DatabaseError
Hinton 4bd0be9
Format
Hinton e2b06a6
Merge branch 'main' of github.com:bitwarden/sdk into ps/sqlite
Hinton 017055b
Fix compile
Hinton File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,32 @@ | ||
mod sqlite; | ||
use std::borrow::Cow; | ||
|
||
pub use sqlite::SqliteDatabase; | ||
use thiserror::Error; | ||
|
||
use crate::MissingFieldError; | ||
|
||
#[derive(Debug, Error)] | ||
pub enum DatabaseError { | ||
#[error("Database lock")] | ||
DatabaseLock, | ||
|
||
#[error("Failed to open connection to database")] | ||
FailedToOpenConnection, | ||
|
||
#[error(transparent)] | ||
Migrator(#[from] MigratorError), | ||
|
||
#[error(transparent)] | ||
Rusqlite(#[from] rusqlite::Error), | ||
#[error(transparent)] | ||
SerdeJson(#[from] serde_json::Error), | ||
#[error(transparent)] | ||
MissingField(#[from] MissingFieldError), | ||
} | ||
|
||
#[derive(Debug, Error)] | ||
pub enum MigratorError { | ||
#[error("Internal error: {0}")] | ||
Internal(Cow<'static, str>), | ||
} |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check failure
Code scanning / clippy
used unwrap() on a Result value Error