Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude unecessary files from published bws #650

Merged
merged 1 commit into from
Mar 4, 2024
Merged

Exclude unecessary files from published bws #650

merged 1 commit into from
Mar 4, 2024

Conversation

Hinton
Copy link
Member

@Hinton Hinton commented Mar 4, 2024

Type of change

- [ ] Bug fix
- [ ] New feature development
- [x] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

Prevent unecessary files from being included in the crates distributed build.

Before you submit

  • Please add unit tests where it makes sense to do so

@Hinton Hinton requested review from dani-garcia and a team March 4, 2024 10:53
@bitwarden-bot
Copy link

Logo
Checkmarx One – Scan Summary & Details5c4979c2-4cbf-4d0b-9407-d9854f1ce7ad

No New Or Fixed Issues Found

Copy link

codecov bot commented Mar 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.53%. Comparing base (621cb48) to head (90fab11).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #650   +/-   ##
=======================================
  Coverage   60.53%   60.53%           
=======================================
  Files         172      172           
  Lines       10527    10527           
=======================================
  Hits         6373     6373           
  Misses       4154     4154           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@dani-garcia dani-garcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I can see those files are already not included in the package:

image

We can probably exclude Cross.toml though, and maybe the changelog too

@Hinton
Copy link
Member Author

Hinton commented Mar 4, 2024

@dani-garcia 0.4.0 was released a while ago when we had cross.toml in the repository. https://github.com/bitwarden/sdk/tree/bws-v0.4.0/crates/bws

You can run cargo package --list to check which files gets included in the release.

@Hinton Hinton requested a review from dani-garcia March 4, 2024 14:39
Copy link
Member

@dani-garcia dani-garcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Somehow I though the last release was pretty recent 🤦

@Hinton Hinton merged commit 300c1f0 into main Mar 4, 2024
64 checks passed
@Hinton Hinton deleted the ps/exclude-bws branch March 4, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants