-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scanning #630
Scanning #630
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #630 +/- ##
=======================================
Coverage 60.52% 60.52%
=======================================
Files 172 172
Lines 10523 10523
=======================================
Hits 6369 6369
Misses 4154 4154 ☔ View full report in Codecov by Sentry. |
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
No New Or Fixed Issues Found |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checkmarx and github isn't syncing up on triaged status. This is a blocker since it makes checkmarx useless. Example being the command injections in the python example, those were marked as not exploitable in checkmarx a while back.
We also have no use for sonar cloud since it doesn't support rust.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did we solve checkmarx not syncing with github?
Objective
Introduces a new GitHub Actions workflow named
Scan
in the.github/workflows/scan.yml
file. The workflow is triggered on manual dispatch, push to themain
,rc
, andhotfix-rc
branches, and when a pull request is opened or synchronized. The workflow includes two jobs:sast
andquality
. Thesast
job runs a Static Application Security Testing (SAST) scan using Checkmarx and uploads the results to GitHub. Thequality
job runs a quality scan using SonarCloud..github/workflows/scan.yml
: Added a new GitHub Actions workflow namedScan
. This workflow is triggered on manual dispatch, push to themain
,rc
, andhotfix-rc
branches, and when a pull request is opened or synchronized. The workflow includes two jobs:sast
andquality
. Thesast
job runs a Static Application Security Testing (SAST) scan using Checkmarx and uploads the results to GitHub. Thequality
job runs a quality scan using SonarCloud.Before you submit