Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-5791] Change decrypt to return Sensitive #536

Merged
merged 29 commits into from
Apr 25, 2024

Review feedback

7baa6f1
Select commit
Loading
Failed to load commit list.
Merged

[PM-5791] Change decrypt to return Sensitive #536

Review feedback
7baa6f1
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Apr 25, 2024 in 0s

61.72% (+0.82%) compared to dc4ad16

View this Pull Request on Codecov

61.72% (+0.82%) compared to dc4ad16

Details

Codecov Report

Attention: Patch coverage is 92.13052% with 41 lines in your changes are missing coverage. Please review.

Project coverage is 61.72%. Comparing base (dc4ad16) to head (7baa6f1).
Report is 5 commits behind head on main.

Files Patch % Lines
crates/bitwarden/src/vault/cipher/cipher.rs 83.33% 27 Missing ⚠️
crates/bitwarden/src/auth/tde.rs 0.00% 3 Missing ⚠️
crates/bitwarden/src/secrets_manager/state.rs 0.00% 3 Missing ⚠️
crates/bitwarden/src/client/encryption_settings.rs 50.00% 2 Missing ⚠️
crates/bitwarden/src/mobile/vault/client_sends.rs 0.00% 2 Missing ⚠️
...n/src/secrets_manager/projects/project_response.rs 0.00% 2 Missing ⚠️
...s/bitwarden/src/mobile/vault/client_attachments.rs 0.00% 1 Missing ⚠️
crates/bitwarden/src/vault/send.rs 95.65% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #536      +/-   ##
==========================================
+ Coverage   60.90%   61.72%   +0.82%     
==========================================
  Files         173      173              
  Lines       10694    10905     +211     
==========================================
+ Hits         6513     6731     +218     
+ Misses       4181     4174       -7

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov