Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-5791] Change decrypt to return Sensitive #536

Merged
merged 29 commits into from
Apr 25, 2024

Merge branch 'main' of github.com:bitwarden/sdk into ps/zeroize-decry…

3d247ad
Select commit
Loading
Failed to load commit list.
Merged

[PM-5791] Change decrypt to return Sensitive #536

Merge branch 'main' of github.com:bitwarden/sdk into ps/zeroize-decry…
3d247ad
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 29, 2024 in 0s

51.66% (-0.04%) compared to bc995a8

View this Pull Request on Codecov

51.66% (-0.04%) compared to bc995a8

Details

Codecov Report

Attention: 57 lines in your changes are missing coverage. Please review.

Comparison is base (bc995a8) 51.69% compared to head (3d247ad) 51.66%.
Report is 9 commits behind head on main.

❗ Current head 3d247ad differs from pull request most recent head b848625. Consider uploading reports for the commit b848625 to get more accurate results

Files Patch % Lines
crates/bitwarden-crypto/src/decrypted.rs 52.08% 23 Missing ⚠️
crates/bitwarden/src/vault/cipher/cipher.rs 11.11% 16 Missing ⚠️
crates/bitwarden/src/uniffi_support.rs 0.00% 7 Missing ⚠️
crates/bitwarden/src/secrets_manager/state.rs 0.00% 3 Missing ⚠️
crates/bitwarden/src/client/encryption_settings.rs 50.00% 2 Missing ⚠️
crates/bitwarden/src/mobile/vault/client_sends.rs 0.00% 2 Missing ⚠️
...n/src/secrets_manager/projects/project_response.rs 0.00% 2 Missing ⚠️
...s/bitwarden/src/mobile/vault/client_attachments.rs 0.00% 1 Missing ⚠️
crates/bitwarden/src/vault/send.rs 92.85% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #536      +/-   ##
==========================================
- Coverage   51.69%   51.66%   -0.04%     
==========================================
  Files         163      164       +1     
  Lines        8202     8275      +73     
==========================================
+ Hits         4240     4275      +35     
- Misses       3962     4000      +38

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov