Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add derive_pin_user_key #508

Merged
merged 6 commits into from
Jan 15, 2024
Merged

Add derive_pin_user_key #508

merged 6 commits into from
Jan 15, 2024

Conversation

Hinton
Copy link
Member

@Hinton Hinton commented Jan 15, 2024

Type of change

- [ ] Bug fix
- [x] New feature development
- [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

Adds support for using pin when require master password is enabled.

Before you submit

  • Please add unit tests where it makes sense to do so

Copy link

codecov bot commented Jan 15, 2024

Codecov Report

Attention: 16 lines in your changes are missing coverage. Please review.

Comparison is base (d2cb4f9) 50.19% compared to head (27d2eb4) 50.43%.

❗ Current head 27d2eb4 differs from pull request most recent head c14c5bf. Consider uploading reports for the commit c14c5bf to get more accurate results

Files Patch % Lines
crates/bitwarden-uniffi/src/crypto.rs 0.00% 10 Missing ⚠️
crates/bitwarden/src/mobile/client_crypto.rs 0.00% 3 Missing ⚠️
crates/bitwarden/src/mobile/crypto.rs 95.52% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #508      +/-   ##
==========================================
+ Coverage   50.19%   50.43%   +0.24%     
==========================================
  Files         157      157              
  Lines        7493     7564      +71     
==========================================
+ Hits         3761     3815      +54     
- Misses       3732     3749      +17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Hinton Hinton changed the title Add derive_protected_pin_key Add derive_pin_user_key Jan 15, 2024
@Hinton Hinton requested a review from dani-garcia January 15, 2024 13:26
dani-garcia
dani-garcia previously approved these changes Jan 15, 2024
# Conflicts:
#	crates/bitwarden/src/mobile/crypto.rs
@Hinton Hinton requested a review from dani-garcia January 15, 2024 15:19
@Hinton Hinton requested a review from dani-garcia January 15, 2024 15:29
@Hinton Hinton merged commit a1e57c1 into main Jan 15, 2024
43 checks passed
@Hinton Hinton deleted the ps/pin branch January 15, 2024 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants