-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PM-5348] Encrypt/decrypt attachment files #490
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #490 +/- ##
==========================================
- Coverage 50.47% 50.01% -0.47%
==========================================
Files 157 159 +2
Lines 7564 7788 +224
==========================================
+ Hits 3818 3895 +77
- Misses 3746 3893 +147 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can better encapsulate the attachment key.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we're missing the use case of creating an attachment. Which also involves creating the key.
I think what we want is a way to create a new attachment which also creates a key. And a way to decrypt existing attachments. There should be no need to use an existing key to encrypt again.
# Conflicts: # crates/bitwarden/src/vault/cipher/attachment.rs
Type of change
Objective
Add encryption/decryption support for attachment files