Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bundle platform-verifier #1039

Merged
merged 1 commit into from
Sep 20, 2024
Merged

Bundle platform-verifier #1039

merged 1 commit into from
Sep 20, 2024

Conversation

Hinton
Copy link
Member

@Hinton Hinton commented Sep 12, 2024

🎟️ Tracking

📔 Objective

We've run into some issues related to rustls-platform-verifier distributing an android library through their crate, which works great if you use platform-verifier within an application. However since we distribute an sdk, the application have difficulties locating the android specific platform-verifier library.

To resolve this we follow the method established in rustls/rustls-platform-verifier#115 and bundle the classes with the library.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation
    team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Detailscee17d3a-f96d-4de7-9668-efcdae153bbe

No New Or Fixed Issues Found

Copy link

codecov bot commented Sep 12, 2024

Codecov Report

Attention: Patch coverage is 0% with 10 lines in your changes missing coverage. Please review.

Project coverage is 58.14%. Comparing base (c04b9a0) to head (4cff6ec).
Report is 21 commits behind head on main.

Files with missing lines Patch % Lines
crates/bitwarden-uniffi/src/lib.rs 0.00% 10 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1039      +/-   ##
==========================================
- Coverage   58.18%   58.14%   -0.04%     
==========================================
  Files         197      197              
  Lines       13487    13496       +9     
==========================================
  Hits         7847     7847              
- Misses       5640     5649       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Hinton Hinton requested a review from dani-garcia September 19, 2024 14:13
@Hinton Hinton merged commit 88537a8 into main Sep 20, 2024
70 of 71 checks passed
@Hinton Hinton deleted the ps/platform-verifier-bundle branch September 20, 2024 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants