Review comments

bitwarden · Mar 7, 2024 · f34c672 · f34c672
1 parent b273fd8
commit f34c672
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 12 deletions.
diff --git a/.github/workflows/memory-testing.yml b/.github/workflows/memory-testing.yml
@@ -1,5 +1,5 @@
 ---
-name: Memory Testing
+name: Test for memory leaks
 
 on:
   pull_request:
@@ -15,17 +15,13 @@ on:
       - "rc"
       - "hotfix-rc"
 
-defaults:
-  run:
-    shell: bash
-
 jobs:
   memory-test:
-    name: Memory Testing
+    name: Testing
     runs-on: ubuntu-22.04
 
     steps:
-      - name: Checkout
+      - name: Check out repo
         uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1
 
       - name: Set up gdb
@@ -43,5 +39,5 @@ jobs:
         with:
           key: memtest-cargo
 
-      - name: Memory Testing
+      - name: Test
         run: ./crates/memory-testing/run_test.sh no-docker
diff --git a/crates/memory-testing/Dockerfile b/crates/memory-testing/Dockerfile
@@ -18,11 +18,9 @@ FROM debian:bookworm-slim
 # This specifically needs to run as root to be able to capture core dumps
 USER root
 
-RUN apt-get update && apt-get install -y --no-install-recommends gdb && apt-get clean && rm -rf /var/lib/apt/lists/*
+RUN apt-get update && apt-get install -y --no-install-recommends gdb=13.1-3 && apt-get clean && rm -rf /var/lib/apt/lists/*
 
 # Copy built project from the build stage
-COPY --from=build /app/target/debug/memory-testing .
-COPY --from=build /app/target/debug/capture-dumps .
-COPY --from=build /app/crates/memory-testing/cases.json .
+COPY --from=build /app/target/debug/memory-testing /app/target/debug/capture-dumps /app/crates/memory-testing/cases.json ./
 
 CMD [ "/capture-dumps", "./memory-testing", "/output" ]