Skip to content

Commit

Permalink
Bump MSRV to 1.75 (#980)
Browse files Browse the repository at this point in the history
## 🎟️ Tracking

<!-- Paste the link to the Jira or GitHub issue or otherwise describe /
point to where this change is coming from. -->

## 📔 Objective

<!-- Describe what the purpose of this PR is, for example what bug
you're fixing or new feature you're adding. -->

The #972 PR requires MSRV 1.73, and #924 will require. MSRV 1.75. To
avoid upgrading twice I suggest immediately changing to 1.75. This is
noted as a change in both the CLI and bitwarden change logs.

## ⏰ Reminders before review

- Contributor guidelines followed
- All formatters and local linters executed and passed
- Written new unit and / or integration tests where applicable
- Protected functional changes with optionality (feature flags)
- Used internationalization (i18n) for all UI strings
- CI builds passed
- Communicated to DevOps any deployment requirements
- Updated any necessary documentation (Confluence, contributing docs) or
informed the documentation
  team

## 🦮 Reviewer guidelines

<!-- Suggested interactions but feel free to use (or not) as you desire!
-->

- 👍 (`:+1:`) or similar for great changes
- 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info
- ❓ (`:question:`) for questions
- 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry
that's not quite a confirmed
  issue and could potentially benefit from discussion
- 🎨 (`:art:`) for suggestions / improvements
- ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or
concerns needing attention
- 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or
indications of technical debt
- ⛏ (`:pick:`) for minor or nitpick changes
  • Loading branch information
Hinton authored Aug 19, 2024
1 parent de3b6e2 commit 2ff096f
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 1 deletion.
2 changes: 1 addition & 1 deletion .github/workflows/minimum-rust-version.yml
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ jobs:
with:
# Important: When updating this, make sure to update the Readme file
# and also the `rust-version` field in all the `Cargo.toml`.
toolchain: 1.71.0
toolchain: 1.75.0
targets: ${{ matrix.settings.target }}

- name: Cache cargo registry
Expand Down
1 change: 1 addition & 0 deletions crates/bitwarden/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
- Secrets Manager now requires `bitwarden::secrets_manager::ClientSecretsExt` and
`bitwarden::secrets_manager::ClientProjectsExt` to be imported in order to access `secrets()` and
`projects` on the client (#798)
- Updated MSRV `1.75.0` (#980)

### Removed

Expand Down
4 changes: 4 additions & 0 deletions crates/bws/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,10 @@ adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

- The ability to edit unassigned secrets with direct permissions. (#906)

### Changed

- Updated MSRV `1.75.0` (#980)

### Removed

- The deprecated `action type` commands are now removed. Please use `type action` instead. (#836)
Expand Down

0 comments on commit 2ff096f

Please sign in to comment.