Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BRE-101] Update CODEOWNERS for CI/CD Partnership Phase 2 #337

Merged
merged 2 commits into from
Oct 22, 2024

Conversation

vgrassia
Copy link
Member

๐ŸŽŸ๏ธ Tracking

๐Ÿ“” Objective

Prepare CODEOWNERS for CI/CD partnership Phase 2:

  • Update team from dept-devops to dept-bre.

โฐ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

๐Ÿฆฎ Reviewer guidelines

  • ๐Ÿ‘ (:+1:) or similar for great changes
  • ๐Ÿ“ (:memo:) or โ„น๏ธ (:information_source:) for notes or general info
  • โ“ (:question:) for questions
  • ๐Ÿค” (:thinking:) or ๐Ÿ’ญ (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • ๐ŸŽจ (:art:) for suggestions / improvements
  • โŒ (:x:) or โš ๏ธ (:warning:) for more significant problems or concerns needing attention
  • ๐ŸŒฑ (:seedling:) or โ™ป๏ธ (:recycle:) for future improvements or indications of technical debt
  • โ› (:pick:) for minor or nitpick changes

@vgrassia vgrassia self-assigned this Oct 22, 2024
@vgrassia vgrassia requested a review from a team as a code owner October 22, 2024 15:55
@vgrassia vgrassia enabled auto-merge (squash) October 22, 2024 15:59
@vgrassia vgrassia merged commit aca93dc into main Oct 22, 2024
5 checks passed
@vgrassia vgrassia deleted the BRE-101-Remove-dept-devops-from-CODEOWNERS branch October 22, 2024 16:10
Copy link

github-actions bot commented Oct 22, 2024

Logo
Checkmarx One โ€“ Scan Summary & Details โ€“ 078e2493-7a06-4906-8da6-2ea33a1d705e

No New Or Fixed Issues Found

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants