Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix workflow by upgrade Ubuntu version #112

Merged
merged 1 commit into from
Dec 2, 2024

Conversation

cesaryuan
Copy link
Contributor

@cesaryuan cesaryuan commented Dec 2, 2024

๐ŸŽŸ๏ธ Tracking

#111
bitwarden/android#4342
https://gitlab.com/fdroid/fdroidserver/-/issues/1246

๐Ÿ“” Objective

Workflow not work anymore

๐Ÿ“ธ Screenshots

โฐ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

๐Ÿฆฎ Reviewer guidelines

  • ๐Ÿ‘ (:+1:) or similar for great changes
  • ๐Ÿ“ (:memo:) or โ„น๏ธ (:information_source:) for notes or general info
  • โ“ (:question:) for questions
  • ๐Ÿค” (:thinking:) or ๐Ÿ’ญ (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • ๐ŸŽจ (:art:) for suggestions / improvements
  • โŒ (:x:) or โš ๏ธ (:warning:) for more significant problems or concerns needing attention
  • ๐ŸŒฑ (:seedling:) or โ™ป๏ธ (:recycle:) for future improvements or indications of technical debt
  • โ› (:pick:) for minor or nitpick changes

@cesaryuan cesaryuan requested a review from a team as a code owner December 2, 2024 02:58
@CLAassistant
Copy link

CLAassistant commented Dec 2, 2024

CLA assistant check
All committers have signed the CLA.

@SaintPatrck SaintPatrck merged commit 992a5c4 into bitwarden:main Dec 2, 2024
5 checks passed
Copy link

github-actions bot commented Dec 2, 2024

Logo
Checkmarx One โ€“ Scan Summary & Details โ€“ fb5fe7d4-9af2-4b00-a34b-f5bc9aaac00b

Fixed Issues

Severity Issue Source File / Package
MEDIUM Unpinned Actions Full Length Commit SHA /fdroid.yml: 44

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants