Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-13789] add credential manager provider for passwords #4110

Open
wants to merge 33 commits into
base: main
Choose a base branch
from

Conversation

Nailik
Copy link

@Nailik Nailik commented Oct 17, 2024

🎟️ Tracking

#4100

📔 Objective

Currently there is only an implementation to provide or save Fido2 credentials via the CredentialManager.
The objective is to add the possibility to save and create Passwords.

Credential Manager usage: https://developer.android.com/identity/sign-in/credential-manager
Credential Provider to provide Credential Manager: https://developer.android.com/identity/sign-in/credential-provider
Example Project: https://github.com/android/identity-samples/tree/main/CredentialManager

Status

  • new BitwardenCredentialProviderService to handle incoming credential requests
  • new CredentialCompletionManager (from Fido2CompletionManager) to handle both passkeys and passwords
  • Overwrite Password/Username combination confirmation dialogs.

Working on:

  • Cleanup (formatting, comments etc)
  • fixing tests / adding tests

Found issues:

  • showFido2ErrorDialog doesn't always show the correct reason, however to stay consistent the showPaswordErrorDialog also shows always the same issue

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@CLAassistant
Copy link

CLAassistant commented Oct 17, 2024

CLA assistant check
All committers have signed the CLA.

@bitwarden-bot
Copy link

Thank you for your contribution! We've added this to our internal Community PR board for review.
ID: PM-13789

@bitwarden-bot bitwarden-bot changed the title [DRAFT] add credential manager provider for passwords [PM-13789] [DRAFT] add credential manager provider for passwords Oct 17, 2024
@Nailik Nailik force-pushed the feature/add-password-credential-manager-provider branch from 9844952 to 5321cda Compare October 17, 2024 16:22
@Nailik Nailik force-pushed the feature/add-password-credential-manager-provider branch from 82730f4 to cab85a9 Compare October 19, 2024 17:25
@Nailik Nailik force-pushed the feature/add-password-credential-manager-provider branch from 4aa9f5a to 5a6e528 Compare October 20, 2024 01:03
Nailik added 10 commits October 20, 2024 03:12
…ialProviderService in order to not show 2 locked entries in the credential api.
…nCredentialProviderService in order to not show 2 locked entries in the credential api."

This reverts commit 1ec7bdd.
…BitwardenCredentialProviderService in order to not show 2 locked entries in the credential api.""

This reverts commit c0190c0.
…pport request for passkeys and passwords at the same time
@Nailik
Copy link
Author

Nailik commented Oct 21, 2024

I would like a check/pre-review from the code owners before starting to work on the tests.

Maybe this could be split into multiple smaller PRs as it got already a lot bigger than i thought it would be - and it's also a lot to review

@Nailik Nailik changed the title [PM-13789] [DRAFT] add credential manager provider for passwords [PM-13789] add credential manager provider for passwords Oct 22, 2024
@djsmith85 djsmith85 linked an issue Nov 11, 2024 that may be closed by this pull request
2 tasks
…ider

# Conflicts:
#	app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/addedit/VaultAddEditViewModel.kt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No Credential Manager Password Prompt
3 participants