[PM-13789] add credential manager provider for passwords #4110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nailik
requested review from
brian-livefront,
david-livefront,
dseverns-livefront,
ahaisting-livefront and
a team
as code owners
|
|
|
Thank you for your contribution! We've added this to our internal Community PR board for review. |
bitwarden-bot
changed the title
Nailik
force-pushed
the
feature/add-password-credential-manager-provider
branch
from
9844952
to
5321cda
Compare
… android.credentials.TYPE_PASSWORD_CREDENTIAL
Nailik
force-pushed
the
feature/add-password-credential-manager-provider
branch
from
82730f4
to
cab85a9
Compare
Nailik
force-pushed
the
feature/add-password-credential-manager-provider
branch
from
4aa9f5a
to
5a6e528
Compare
…ialProviderService in order to not show 2 locked entries in the credential api.
…nCredentialProviderService in order to not show 2 locked entries in the credential api." This reverts commit 1ec7bdd.
…BitwardenCredentialProviderService in order to not show 2 locked entries in the credential api."" This reverts commit c0190c0.
…pport request for passkeys and passwords at the same time
|
I would like a check/pre-review from the code owners before starting to work on the tests. Maybe this could be split into multiple smaller PRs as it got already a lot bigger than i thought it would be - and it's also a lot to review |
Nailik
changed the title
…ider # Conflicts: # app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/addedit/VaultAddEditViewModel.kt
2 tasks
…ider # Conflicts: # app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/addedit/VaultAddEditViewModel.kt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
#4100
📔 Objective
Currently there is only an implementation to provide or save Fido2 credentials via the CredentialManager.
The objective is to add the possibility to save and create Passwords.
Credential Manager usage: https://developer.android.com/identity/sign-in/credential-manager
Credential Provider to provide Credential Manager: https://developer.android.com/identity/sign-in/credential-provider
Example Project: https://github.com/android/identity-samples/tree/main/CredentialManager
Status
Working on:
Found issues:
showFido2ErrorDialogdoesn't always show the correct reason, however to stay consistent theshowPaswordErrorDialogalso shows always the same issue📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmedissue and could potentially benefit from discussion
:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes