-
Notifications
You must be signed in to change notification settings - Fork 842
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
PM-11224 Add menu to update feature flags with overridden values in r…
…eal time (#3838)
- Loading branch information
1 parent
2a057bb
commit 3c39d8b
Showing
29 changed files
with
1,451 additions
and
17 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
19 changes: 19 additions & 0 deletions
19
...n/java/com/x8bit/bitwarden/data/platform/datasource/disk/FeatureFlagOverrideDiskSource.kt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| package com.x8bit.bitwarden.data.platform.datasource.disk | ||
|
|
||
| import com.x8bit.bitwarden.data.platform.manager.model.FlagKey | ||
|
|
||
| /** | ||
| * Disk data source for saved feature flag overrides. | ||
| */ | ||
| interface FeatureFlagOverrideDiskSource { | ||
|
|
||
| /** | ||
| * Save a feature flag [FlagKey] to disk. | ||
| */ | ||
| fun <T : Any> saveFeatureFlag(key: FlagKey<T>, value: T) | ||
|
|
||
| /** | ||
| * Get a feature flag value based on the associated [FlagKey] from disk. | ||
| */ | ||
| fun <T : Any> getFeatureFlag(key: FlagKey<T>): T? | ||
| } |
37 changes: 37 additions & 0 deletions
37
...va/com/x8bit/bitwarden/data/platform/datasource/disk/FeatureFlagOverrideDiskSourceImpl.kt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,37 @@ | ||
| package com.x8bit.bitwarden.data.platform.datasource.disk | ||
|
|
||
| import android.content.SharedPreferences | ||
| import com.x8bit.bitwarden.data.platform.manager.model.FlagKey | ||
|
|
||
| /** | ||
| * Default implementation of the [FeatureFlagOverrideDiskSource] | ||
| */ | ||
| class FeatureFlagOverrideDiskSourceImpl( | ||
| sharedPreferences: SharedPreferences, | ||
| ) : FeatureFlagOverrideDiskSource, BaseDiskSource(sharedPreferences) { | ||
|
|
||
| override fun <T : Any> saveFeatureFlag(key: FlagKey<T>, value: T) { | ||
| when (key.defaultValue) { | ||
| is Boolean -> putBoolean(key.keyName, value as Boolean) | ||
| is String -> putString(key.keyName, value as String) | ||
| is Int -> putInt(key.keyName, value as Int) | ||
| else -> Unit | ||
| } | ||
| } | ||
|
|
||
| @Suppress("UNCHECKED_CAST") | ||
| override fun <T : Any> getFeatureFlag(key: FlagKey<T>): T? { | ||
| return try { | ||
| when (key.defaultValue) { | ||
| is Boolean -> getBoolean(key.keyName) as? T | ||
| is String -> getString(key.keyName) as? T | ||
| is Int -> getInt(key.keyName) as? T | ||
| else -> null | ||
| } | ||
| } catch (castException: ClassCastException) { | ||
| null | ||
| } catch (numberFormatException: NumberFormatException) { | ||
| null | ||
| } | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
37 changes: 37 additions & 0 deletions
37
...rc/main/java/com/x8bit/bitwarden/data/platform/manager/DebugMenuFeatureFlagManagerImpl.kt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,37 @@ | ||
| package com.x8bit.bitwarden.data.platform.manager | ||
|
|
||
| import com.x8bit.bitwarden.data.platform.manager.model.FlagKey | ||
| import com.x8bit.bitwarden.data.platform.repository.DebugMenuRepository | ||
| import kotlinx.coroutines.flow.Flow | ||
| import kotlinx.coroutines.flow.map | ||
|
|
||
| /** | ||
| * The [FeatureFlagManager] implementation for the debug menu. This manager uses the | ||
| * values returned from the [debugMenuRepository] if they are available. otherwise it will use | ||
| * the default [FeatureFlagManager]. | ||
| */ | ||
| class DebugMenuFeatureFlagManagerImpl( | ||
| private val defaultFeatureFlagManager: FeatureFlagManager, | ||
| private val debugMenuRepository: DebugMenuRepository, | ||
| ) : FeatureFlagManager by defaultFeatureFlagManager { | ||
|
|
||
| override fun <T : Any> getFeatureFlagFlow(key: FlagKey<T>): Flow<T> { | ||
| return debugMenuRepository.featureFlagOverridesUpdatedFlow.map { _ -> | ||
| debugMenuRepository | ||
| .getFeatureFlag(key) | ||
| ?: defaultFeatureFlagManager.getFeatureFlag(key = key) | ||
| } | ||
| } | ||
|
|
||
| override suspend fun <T : Any> getFeatureFlag(key: FlagKey<T>, forceRefresh: Boolean): T { | ||
| return debugMenuRepository | ||
| .getFeatureFlag(key) | ||
| ?: defaultFeatureFlagManager.getFeatureFlag(key = key, forceRefresh = forceRefresh) | ||
| } | ||
|
|
||
| override fun <T : Any> getFeatureFlag(key: FlagKey<T>): T { | ||
| return debugMenuRepository | ||
| .getFeatureFlag(key) | ||
| ?: defaultFeatureFlagManager.getFeatureFlag(key = key) | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
35 changes: 35 additions & 0 deletions
35
app/src/main/java/com/x8bit/bitwarden/data/platform/repository/DebugMenuRepository.kt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,35 @@ | ||
| package com.x8bit.bitwarden.data.platform.repository | ||
|
|
||
| import com.x8bit.bitwarden.data.platform.manager.model.FlagKey | ||
| import kotlinx.coroutines.flow.Flow | ||
|
|
||
| /** | ||
| * Repository for accessing data required or associated with the debug menu. | ||
| */ | ||
| interface DebugMenuRepository { | ||
|
|
||
| /** | ||
| * Value to determine if the debug menu is enabled. | ||
| */ | ||
| val isDebugMenuEnabled: Boolean | ||
|
|
||
| /** | ||
| * Observable flow for when any of the feature flag overrides have been updated. | ||
| */ | ||
| val featureFlagOverridesUpdatedFlow: Flow<Unit> | ||
|
|
||
| /** | ||
| * Update a feature flag which matches the given [key] to the given [value]. | ||
| */ | ||
| fun <T : Any> updateFeatureFlag(key: FlagKey<T>, value: T) | ||
|
|
||
| /** | ||
| * Get a feature flag value based on the associated [FlagKey]. | ||
| */ | ||
| fun <T : Any> getFeatureFlag(key: FlagKey<T>): T? | ||
|
|
||
| /** | ||
| * Reset all feature flag overrides to their default values or values from the network. | ||
| */ | ||
| fun resetFeatureFlagOverrides() | ||
| } |
Oops, something went wrong.