Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tzdata terminating host application v1.1 #766

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

shegx01
Copy link

@shegx01 shegx01 commented Oct 21, 2024

Summary of changes

Fix issue with tzdata v1.1 terminating the host application server

I'll review the commits, so I mostly want to understand the "why" rather than the "what"

Checklist

  • New functions have typespecs, changed functions were updated
  • Same for documentation, including moduledocs
  • Tests were added or updated to cover changes
  • Commits were squashed into a single coherent commit
  • Notes added to CHANGELOG file which describe changes at a high-level

@corroded
Copy link

@shegx01 could it be because of this? lau/tzdata#148

I keep encountering this in our logs - but it shouldn't terminate your host application server unless it fails to report errors or something? 🤔

@kaylenmistry
Copy link

@shegx01 could it be because of this? lau/tzdata#148

I keep encountering this in our logs - but it shouldn't terminate your host application server unless it fails to report errors or something? 🤔

Does not terminate the application, however would be nice to suppress this error log. Any chance we can proceed with this change? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants