Clarify that non power-of-two lengths are valid #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the layer has 7 pieces, and clients wish to request this in chunks, it is valid to send two messages: 1. index = 0, length = 4 2. index = 4, length = 3 Let's hardcode this into the spec as a 'MUST' so anyone implementing the spec has unambiguous guidance. Existing clients adhere to this as far as I can make out.
alanmcgovern
commented
Jun 9, 2022
alanmcgovern
commented
Jun 9, 2022
alanmcgovern
commented
Jun 9, 2022
| @@ -444,7 +444,8 @@ to the leaf and piece layers. Index is the offset in hashes | |||
| of the first requested hash in the base layer. | |||
| Index MUST be a multiple of length, this includes zero. | |||
| Length is the number of hashes to include from the base layer. | |||
| Length MUST be equal-to-or-greater-than two and a power of two. | |||
| Length MUST be equal-to-or-greater-than two and a power of two unless it | |||
| gets truncated by the end of the layer. | |||
There was a problem hiding this comment.
This is mimicking
'request' messages contain an index, begin, and length. The last
two are byte offsets. Length is generally a power of two unless it
gets truncated by the end of a file. All current implementations use
2^14 (16 kiB), and close connections which request an amount greater than
that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the layer has 7 pieces, and clients wish to request this in chunks, it is valid to send two messages:
Let's hardcode this into the spec as a 'MUST' so anyone implementing the spec has unambiguous
guidance. Existing clients adhere to this as far as I can make out.
Addresses #128