Reimplement based on Ken Shoemake's Euler angle conversion from Graphics Gems IV #537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
bitshifter
commented
Jul 14, 2024
bitshifter
commented
- Adds all 24 possible Euler angle combinations including intrinsic and extrinsic rotations.
- Improves numeric accuracy
- Fixes problem with resulting angles being outside of the expected range
Most tests pass except for some quat::rotate_towards fails. Also using matrix methods for quats.
Still need to decide what to do with matrix scale and try add jiggle to tests.
When creating a quaternion from a matrix or extracting Euler angles from a matrix we do not support handling matrices that contain non-rotation transformations. Make that clear in the doc comments and add glam asserts that check inputs in these cases.
It resulted in a large loss of precision in some cases. Should have another look at what Imath is doing instead.
This was referenced Jul 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.