Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve null and boolean assertions #287

Merged
merged 1 commit into from
Jan 26, 2024
Merged

Improve null and boolean assertions #287

merged 1 commit into from
Jan 26, 2024

Conversation

peter279k
Copy link
Contributor

Changed log

  • Using the assertNull to assert the expected is null.
  • Using the assertFalse and assertTrue to assert the expected is true or false boolean.

bobbrodie
bobbrodie approved these changes Jan 26, 2024
View reviewed changes
Copy link
Collaborator

@bobbrodie bobbrodie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@bobbrodie bobbrodie merged commit 2a0bdc1 into bitpay:8.0.x Jan 26, 2024
4 checks passed
@peter279k peter279k deleted the improve_assertion branch January 26, 2024 14:10
bobbrodie added a commit to bobbrodie/php-bitpay-client-v2 that referenced this pull request Mar 29, 2024
@bobbrodie
Re-implement PR bitpay#287 for 9.0.x
b57e4cd
@bobbrodie bobbrodie mentioned this pull request Mar 29, 2024
Merged
bobbrodie added a commit that referenced this pull request Apr 4, 2024
@bobbrodie
Merge pull request #295 from bobbrodie/pull-287-9.0.x
b0a574e 
Reimplement PR #287 for SDK 9.0.x
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bobbrodie bobbrodie bobbrodie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@peter279k @bobbrodie