Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed dup check in address test #3247

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

lukerhoads
Copy link

No description provided.

kajoseph
kajoseph previously approved these changes Aug 19, 2021
Copy link
Collaborator

@kajoseph kajoseph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@kajoseph
Copy link
Collaborator

Hey @lukerhoads , thanks for your contribution! You'll need to sign your commits before I'm able to merge this in. :)

Once you've configured your signing key, you'll need to rebase your branch to only have signed commits
(see https://gist.github.com/mattrobertsky/2072b0a1ab81e824a6a5d38240e20b46)

@lukerhoads
Copy link
Author

lukerhoads commented Aug 20, 2021

You can probably avoid merging this just now, there are some more issues I am not on PC so cannot sign them right now

Such as the duplicate in questions about the address

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants