Reject invalid command from React Native #343
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krocard
force-pushed
the
PRN-92/refactor--throw-on-invalid-rn-input
branch
from
27c2e45
to
ec281e5
Compare
krocard
changed the base branch from
PRN-74/refactor--improve-null-safety
to
PRN-92/refactor--remove-rejectpromiseonexceptionblock
krocard
commented
Dec 6, 2023
| fun ReadableMap.toRNStyleConfigWrapperFromPlayerConfig(): RNStyleConfigWrapper? { | ||
| return RNStyleConfigWrapper( | ||
| fun ReadableMap.toRNStyleConfigWrapperFromPlayerConfig(): RNStyleConfigWrapper? = getMap("styleConfig")?.run { | ||
| RNStyleConfigWrapper( | ||
| styleConfig = toStyleConfig(), |
There was a problem hiding this comment.
There was a silent bug here: toStyleConfig was always returning null as called on the player config.
krocard
changed the title
krocard
changed the title
This was referenced Dec 6, 2023
rolandkakonyi
deleted the
PRN-92/refactor--throw-on-invalid-rn-input
branch
rolandkakonyi
restored the
PRN-92/refactor--throw-on-invalid-rn-input
branch
|
Oops, deleted branch by accident, restored now! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem (PRN-92)
Changes
📚 Other PRs for this issue