[MRG] Add bmc proxies #231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgonnav
suggested changes
Sep 15, 2023
| if delete: | ||
| for env_var in env_vars_instance: | ||
| if env_var.name not in [value["name"] for value in env_vars]: | ||
| env_var.delete() |
There was a problem hiding this comment.
Why add a delete argument for this function?
There was a problem hiding this comment.
7 tasks
mgonnav
suggested changes
Sep 19, 2023
mgonnav
suggested changes
Oct 9, 2023
| to="core.spider", | ||
| ), | ||
| ), | ||
| ] |
There was a problem hiding this comment.
We shouldn't be deleting this migrations file. We also need to generate new migrations for the Proxy model.
| datacenter_proxy_usage = models.PositiveBigIntegerField( | ||
| default=0, | ||
| help_text="Amount in bytes occupied by datacenter proxy responses in the database", | ||
| ) |
There was a problem hiding this comment.
We need to give this a bit more thought. What if we want to add ISP or mobile proxies? We would also need to add a field for each. I am not sure if there are more kinds of proxies, but it isn't a good design having to add more fields for each of them here 🤔
| proxy_usage_data = models.JSONField( | ||
| default=dict, | ||
| help_text="Proxy Usage data.", | ||
| ) |
There was a problem hiding this comment.
I think it would be good to add a comment on how the proxy_usage_data would look. What fields would this JSON have?
mgonnav
approved these changes
Oct 18, 2023
mgonnav
added a commit
that referenced
this pull request
Nov 1, 2023
* [MRG] Add bmc proxies (#231) * Add Estela Proxies. --------- Co-authored-by: mgonnav <[email protected]> * Update RESERVED_PROXY_NAMES variable name. Add download size settings as variables * Add PROXY_PROVIDERS_TO_TRACK, MAX_WEB_DOWNLOAD_SIZE_MB, and MAX_CLI_DOWNLOAD_CHUNK_MB to the API docs --------- Co-authored-by: joaquin garmendia <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issue
Checklist before requesting a review