Skip to content

Commit

Permalink
Fix details overflow in the job and cronjob detail sections
Browse files Browse the repository at this point in the history
  • Loading branch information
@reqhiem
reqhiem committed Aug 21, 2023
1 parent 1a1789f commit b1035aa
Show file tree
Hide file tree
Showing 2 changed files with 22 additions and 24 deletions.
19 changes: 9 additions & 10 deletions estela-web/src/pages/CronJobDetailPage/index.tsx
View file
Original file line number Diff line number Diff line change
Expand Up @@ -856,12 +856,11 @@ export class CronJobDetailPage extends Component<RouteComponentProps<RouteParams
</Row>
<Row className="grid grid-cols-3 bg-estela-blue-low py-1 px-4 rounded-lg">
<Col>Spider</Col>
<Col>
<Link
to={`/projects/${this.projectId}/spiders/${this.spiderId}`}
className="text-estela-blue-medium"
>
{spiderName}
<Col className="col-span-2">
<Link to={`/projects/${this.projectId}/spiders/${this.spiderId}`}>
<Text ellipsis={true} className="text-estela-blue-medium">
{spiderName}
</Text>
</Link>
</Col>
</Row>
Expand Down Expand Up @@ -899,8 +898,8 @@ export class CronJobDetailPage extends Component<RouteComponentProps<RouteParams
</Row>
<Row className="grid grid-cols-3 bg-estela-blue-low py-1 px-4">
<Col>Tags</Col>
<Col>
<Space direction="horizontal">
<Col className="col-span-2">
<Space direction="horizontal" className="flex flex-wrap">
{tags.map((tag: TagsData, id) => (
<Tag
className="border-estela-blue-full bg-estela-blue-low text-estela-blue-full rounded-md"
Expand Down Expand Up @@ -947,8 +946,8 @@ export class CronJobDetailPage extends Component<RouteComponentProps<RouteParams
</Row>
<Row className="grid grid-cols-3 bg-estela-blue-low py-1 px-4">
<Col>Arguments</Col>
<Col>
<Space direction="horizontal">
<Col className="col-span-2">
<Space direction="horizontal" className="flex flex-wrap">
{args.map((arg: ArgsData, id) => (
<Tag
className="border-estela-blue-full bg-estela-blue-low text-estela-blue-full rounded-md"
Expand Down
27 changes: 13 additions & 14 deletions estela-web/src/pages/JobDetailPage/index.tsx
View file
Original file line number Diff line number Diff line change
Expand Up @@ -726,12 +726,11 @@ export class JobDetailPage extends Component<RouteComponentProps<RouteParams>, J
<Col>
<Text className="font-bold">Spider</Text>
</Col>
<Col>
<Link
to={`/projects/${this.projectId}/spiders/${this.spiderId}`}
className="text-estela-blue-medium px-2"
>
{spiderName}
<Col className="col-span-2">
<Link to={`/projects/${this.projectId}/spiders/${this.spiderId}`}>
<Text ellipsis={true} className="text-estela-blue-medium px-2">
{spiderName}
</Text>
</Link>
</Col>
</Row>
Expand Down Expand Up @@ -775,8 +774,8 @@ export class JobDetailPage extends Component<RouteComponentProps<RouteParams>, J
<Col>
<Text className="font-bold">Tags</Text>
</Col>
<Col className="px-2">
<Space direction="horizontal">
<Col className="col-span-2 px-2">
<Space direction="horizontal" className="flex flex-wrap">
{tags.map((tag: TagsData, id) => (
<Tag
className="border-estela-blue-full bg-estela-blue-low text-estela-blue-full rounded-md"
Expand All @@ -795,8 +794,8 @@ export class JobDetailPage extends Component<RouteComponentProps<RouteParams>, J
<Col>
<Text className="font-bold">Environment variables</Text>
</Col>
<Col className="px-2">
<Space direction="vertical">
<Col className="col-span-2 px-2">
<Space direction="vertical" className="flex flex-wrap">
{envVars.map((envVar: SpiderJobEnvVar, id) =>
envVar.masked ? (
<AntdTooltip
Expand Down Expand Up @@ -827,8 +826,8 @@ export class JobDetailPage extends Component<RouteComponentProps<RouteParams>, J
<Col>
<Text className="font-bold">Arguments</Text>
</Col>
<Col className="px-2">
<Space direction="horizontal">
<Col className="col-span-2 px-2">
<Space direction="horizontal" className="flex flex-wrap">
{args.map((arg: ArgsData, id) => (
<Tag
className="border-estela-blue-full bg-estela-blue-low text-estela-blue-full rounded-md"
Expand All @@ -843,7 +842,7 @@ export class JobDetailPage extends Component<RouteComponentProps<RouteParams>, J
</Space>
</Col>
</Row>
<Row className="grid grid-cols-3 bg-estela-blue-low py-1 px-2 rounded-lg">
<Row className="grid grid-cols-3 py-1 px-2 rounded-lg">
<Col>
<Text className="font-bold">Job Status</Text>
</Col>
Expand Down Expand Up @@ -897,7 +896,7 @@ export class JobDetailPage extends Component<RouteComponentProps<RouteParams>, J
</Col>
)}
</Row>
<Row className="grid grid-cols-3 py-1 px-2">
<Row className="grid grid-cols-3 bg-estela-blue-low py-1 px-2">
<Col>
<Text className="font-bold">Data Persistence</Text>
</Col>
Expand Down

0 comments on commit b1035aa

Please sign in to comment.