Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show only interval stats log during debug #94

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

stiangrindvoll
Copy link

Displaying this log generates a lot of noise in centralized logging when
using multiple instances of statsdaemon.

Also fits better to hide this in according with the -debug flag description.

Displaying this log generates a lot of noise in centralized logging when
using multiple instances of statsdaemon.
@ploxiln
Copy link
Contributor

ploxiln commented Aug 31, 2018

I like to see this message in the logs, to know statsdaemon is working, and receiving roughly the correct volume of stats keys from applications ... but debug level logs every single individual stat, which is way too much.

So I think what would be better is adding a log-level option, which could be [debug, info, warning, error], and you would probably prefer running at the "warning" level.

@jehiah
Copy link
Member

jehiah commented Aug 31, 2018

@ploxiln I also use these as a sort of canary, but I think there is a need for a better way to first-class healthcheck statsdaemon to know it's sending metrics. I'm not sure the best way for that, but if such a thing exists, then moving this log to debug (or other more granular logging selections) is fine by me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants