Avoid wasting cycles on lines that are drawn off-screen. #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
byteManiak
commented
Jan 27, 2021
There was a problem hiding this comment.
This comes about as I was trying to implement a 3D wireframe engine using the line() method.
For example, lines that are part of a flat surface would get longer the closer you get to the surface. Any lines that are off-screen at that point incur a penalty in framerate, and besides there is no point in drawing them.
byteManiak
changed the title
added 2 commits
January 27, 2021 20:59
…. The coordinates are recalculated to draw a line that is in the bounds of the screen.
|
Thank you. I will have a look at your patch. |
|
Yes, I intend to opensource the engine once I finish it. For now it's considered private university project work :( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.