Skip to content

Commit

Permalink
Fix protocolVersion checks #90
Browse files Browse the repository at this point in the history
  • Loading branch information
sphlabs committed Apr 7, 2023
1 parent a19b9fb commit e327a4d
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions index.js
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ const { initFeedbacks } = require('./feedbacks')
const { upgradeScripts } = require('./upgrades')
const { CONFIG_MODELS } = require('./models')
const { ConfigFields } = require('./config')
const { protocolGte } = require('./util')

/**
* Companion instance class for the Blackmagic HyperDeck Disk Recorders.
Expand Down Expand Up @@ -309,7 +310,7 @@ class HyperdeckInstance extends InstanceBase {
notify.slot = true
notify.remote = true
// if (isMinimumVersion(1, 11) && this.config.timecodeVariables === 'notifications') notify.displayTimecode = true
if (this.protocolVersion >= 1.11 && this.config.timecodeVariables === 'notifications')
if (protocolGte(this.protocolVersion, '1.11') && this.config.timecodeVariables === 'notifications')
notify.displayTimecode = true
await this.hyperDeck.sendCommand(notify)

Expand Down Expand Up @@ -525,7 +526,7 @@ class HyperdeckInstance extends InstanceBase {
}

if (
this.protocolVersion >= 1.11 &&
protocolGte(this.protocolVersion, '1.11') &&
this.config.timecodeVariables !== config.timecodeVariables &&
!resetConnection
) {
Expand Down

0 comments on commit e327a4d

Please sign in to comment.