-
-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incorporate latest changes from WebDAV-Push #60
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Arnau Mora Gras <[email protected]>
Signed-off-by: Arnau Mora Gras <[email protected]>
Signed-off-by: Arnau Mora Gras <[email protected]>
Signed-off-by: Arnau Mora Gras <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about unit tests for the properties like PushPublicKey
which have some more methods. Not sure if everything is covered in WebPushTest
, so having seperate test classes per property might make sense, no ?
Or does it not make sense to add exhaustive tests yet, since it's still all experimental?
Maybe also a question for @rfc2822
Looks okay otherwise, though I am unsure whether everything is working correctly without test coverage which could be inspected.
Signed-off-by: Arnau Mora Gras <[email protected]>
src/main/kotlin/at/bitfire/dav4jvm/property/push/PushPublicKey.kt
Outdated
Show resolved
Hide resolved
Signed-off-by: Arnau Mora Gras <[email protected]>
Added:
PushPublicKey
: An abstract class that provides the logic for all public key properties:ClientPublicKey
ServerPublicKey
AuthSecret
(forPushPublicKey
)WebPushSubscription
: now also hasclientPublicKey
andauthSecret
PushResource
(forWebPushSubscription
, replaces theString
property)PushTransport
an interface ofProperty
that tags all the push transports (right now onlyWebPush
)WebPush
: comes from the simpler property ofweb-push
, but now has an optionalServerPublicKey
Modified:
https://bitfire.at/webdav-push
PushMessage
: Now haspropStat
instead oftopic
PushTransports
:transports
is now a set ofPushTransport
Renamed:
PushSubscribe
->PushRegister