Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorporate latest changes from WebDAV-Push #60

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

ArnyminerZ
Copy link
Member

@ArnyminerZ ArnyminerZ commented Nov 18, 2024

Added:

  • PushPublicKey: An abstract class that provides the logic for all public key properties:
    • ClientPublicKey
    • ServerPublicKey
  • AuthSecret (for PushPublicKey)
  • WebPushSubscription: now also has clientPublicKey and authSecret
  • PushResource (for WebPushSubscription, replaces the String property)
  • PushTransport an interface of Property that tags all the push transports (right now only WebPush)
  • WebPush: comes from the simpler property of web-push, but now has an optional ServerPublicKey

Modified:

  • Changed namespace to https://bitfire.at/webdav-push
  • PushMessage: Now has propStat instead of topic
  • PushTransports: transports is now a set of PushTransport

Renamed:

  • PushSubscribe -> PushRegister

@ArnyminerZ ArnyminerZ linked an issue Nov 18, 2024 that may be closed by this pull request
@ArnyminerZ ArnyminerZ self-assigned this Nov 18, 2024
Signed-off-by: Arnau Mora Gras <[email protected]>
@ArnyminerZ ArnyminerZ marked this pull request as ready for review November 18, 2024 07:54
@rfc2822 rfc2822 requested review from sunkup and removed request for rfc2822 November 18, 2024 10:52
Copy link
Member

@sunkup sunkup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about unit tests for the properties like PushPublicKey which have some more methods. Not sure if everything is covered in WebPushTest, so having seperate test classes per property might make sense, no ?

Or does it not make sense to add exhaustive tests yet, since it's still all experimental?

Maybe also a question for @rfc2822

Looks okay otherwise, though I am unsure whether everything is working correctly without test coverage which could be inspected.

Signed-off-by: Arnau Mora Gras <[email protected]>
Signed-off-by: Arnau Mora Gras <[email protected]>
@rfc2822 rfc2822 removed their request for review November 25, 2024 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorporate latest changes from WebDAV-Push
3 participants