Add reserved length setting #201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ufoscout
requested changes
Jan 11, 2024
ic-stable-structures/src/memory_mapped_files/memory_mapped_file.rs
Outdated
Show resolved
Hide resolved
ufoscout
approved these changes
Jan 11, 2024
veeso
approved these changes
Jan 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before we were reserving 1 TB of virtual memory space for each memory-mapped file. Which is OK for a single x64 application which has 2^48/2 = 128 TB user address space. But if we are running EVMC tests concurrently where several dozens of files are created for each state we may end up getting memory allocation error (which is actually address space allocation error).
That's why I've added a possibility to change the default reserved length, now it is used in tests only.