Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(refactor) Update React to 18 [waiting for build fix] #192

Closed
wants to merge 6 commits into from

Conversation

dmytroshch
Copy link
Contributor

@dmytroshch dmytroshch commented Aug 10, 2023

Prerequisites

N/A

(If the PR requires any other PRs to be applied first, indicate it here, otherwise put "N/A")

Task reference

BREAKING CHANGES

N/A

(Explain here, any breaking changes that do not have backward compatibility with previous versions of ufx-ui or keep N/A
i.e. if you renamed some component prop. Someone who is using previous version, should work on these updates, before upating their ufx-ui dependency to this version)

PR description

Example app screenshot

Screenshot from 2023-08-10 13-30-57

(Add example app screenshot if applicable, otherwise put "N/A")

Storybook screenshot

Screenshot from 2023-08-10 13-31-33

(Add storybook screenshot if applicable, otherwise put "N/A")

Checklist

  • PR title has category name prefix, e.g. "(fix) {description}" (fix/feature/refactor/improvement/doc/test)
  • Added PR description
  • Relevant change in example app is verified, added example app screenshot
  • Storybook: stories, docs are updated/verified
  • Pull request verify workflow passed
  • PR development is completed, the developer is satisfied with the code quality and behavior of the app

@dmytroshch dmytroshch changed the title Update React to 18 (feature) Update React to 18 Aug 10, 2023
@dmytroshch dmytroshch changed the title (feature) Update React to 18 (refactor) Update React to 18 Aug 10, 2023
@bhoomij bhoomij changed the title (refactor) Update React to 18 (refactor) Update React to 18 [waiting for build fix] Aug 24, 2023
@bhoomij bhoomij marked this pull request as draft August 24, 2023 12:49
@bhoomij
Copy link
Contributor

bhoomij commented Aug 30, 2023

we have to use react 16.9. 0 to make it work with node 16 + connected-react-router

@bhoomij bhoomij closed this Aug 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants