replace shuffle

bitfinexcom · Nov 2, 2023 · 1aa1b9b · 1aa1b9b
1 parent 8928cca
commit 1aa1b9b
Showing 1 changed file with 3 additions and 5 deletions.
diff --git a/src/shuffle.js b/src/shuffle.js
@@ -9,11 +9,9 @@
 const shuffle = (array) => {
  const clone = [...array]
  const length = clone.length
- for (let i = 0; i < length; i++) {
- const mov = Math.floor(Math.random() * length)
- const tmp = clone[mov]
- clone[mov] = clone[i]
- clone[i] = tmp
+ for (let i = length - 1; i > 0; i--) {
+ const index = Math.floor(Math.random() * (i + 1)); // random index from 0 to i
+ [clone[i], clone[index]] = [clone[index], clone[i]] // swap elements
  }
 
  return clone