Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[4.21.0] - 2024-03-20
Added
PDFBufferUnderElectronCreationError
error to use WebSockets to inform users for better UX. PRs: bfx-report#354, bfx-reports-framework#359emitReportFileGenerationFailedToOne
ws events on UI side to inform users about report generation failing. PR: bfx-report-ui#787publicCollsConf
table name with Cyrillicc
. PR: bfx-reports-framework#360c
. PR: bfx-report-ui#788Changed
GH Actions
to use Nodejsv20
to prevent breaking changes in workflow. PRs: bfx-report#355, bfx-reports-framework#361, bfx-report-electron#344, bfx-facs-db-better-sqlite#9deprecated
reports generation methods usage to the actual ones according to the latest backend changes. PR: bfx-report-ui#784Market History / Spot
section according to the latest UX improvement proposals: We should allow the user to remove the current pair and display an empty table that saysNo history to display
. PR: bfx-report-ui#786electron-log
lib. Suppressed error modal window if pdf gen failed: the idea here is to inform the user if something goes wrong using WS event for better UX instead of showing a modal window error as it is annoying in most cases. Improved pdf generation performance for big html templates, usesloadFile
method of electron api instead ofbase64
encoding. Bumped up Electronjs minor version to have the last fixes. PR: bfx-report-electron#342Fixed