bitfinexcom · ezewer · Mar 6, 2024 · Jan 11, 2024 · Feb 8, 2024 · Feb 8, 2024
diff --git a/.dockerignore b/.dockerignore
@@ -15,6 +15,7 @@ bfx-reports-framework/config/*.json
 bfx-reports-framework/config/facs/*.json
 bfx-reports-framework/logs/*.log
 bfx-reports-framework/csv
+bfx-reports-framework/report-files
 bfx-report-ui/build
 bfx-report-ui/bfx-report-express/logs/*.log
 bfx-report-ui/bfx-report-express/config/*.json

diff --git a/.env.example b/.env.example
@@ -1,3 +1,4 @@
+REPO_OWNER=bitfinexcom
 REPO_BRANCH=master
 IS_BFX_API_STAGING=0
 IS_DEV_ENV=0

diff --git a/.github/workflows/build-electron-app.yml b/.github/workflows/build-electron-app.yml
@@ -22,6 +22,9 @@ on:
  isNotarizeDisabled:
  description: 'Is notarize disabled (true / 1)?'
  required: false
+ repoOwner:
+ description: 'Repository owner for auto-update'
+ required: false
 
 env:
  DOCKER_BUILDKIT: 1
@@ -36,11 +39,6 @@ jobs:
  uses: actions/checkout@v4
  with:
  submodules: recursive
- - name: Set repo owner
- run: |
- sed -i -e \
- "s/owner: '.*'/owner: '${{ github.repository_owner }}'/g" \
- "./electron-builder-config.js"
  - if: github.event.inputs.version != ''
  name: Set release version
  run: |
@@ -55,9 +53,16 @@ jobs:
  name: Use BFX API Staging for queries
  run: |
  echo "IS_BFX_API_STAGING=1" >> $GITHUB_ENV
+ - name: Set repository owner for auto-update
+ run: |
+ if [[ "${{ github.event.inputs.repoOwner }}" != "" ]]; then
+ echo "REPO_OWNER=${{ github.event.inputs.repoOwner }}" >> $GITHUB_ENV
+ else
+ echo "REPO_OWNER=${{ github.repository_owner }}" >> $GITHUB_ENV
+ fi
  - name: Cache Electron binaries
  id: electron-cache
- uses: actions/cache@v3
+ uses: actions/cache@v4
  env:
  cache-name: electron-cache-v1
  with:
@@ -69,7 +74,7 @@ jobs:
  ${{ runner.os }}-build-${{ env.cache-name }}-
  - name: Build release
  id: release-builder
- uses: nick-fields/retry@v2
+ uses: nick-fields/retry@v3
  continue-on-error: false
  env:
  GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
@@ -82,14 +87,14 @@ jobs:
  - name: Zip Linux Unpacked build
  run: zip -r dist/linux-unpacked.zip dist/linux-unpacked
  - name: Upload Linux Unpacked build
- uses: actions/upload-artifact@v3
+ uses: actions/upload-artifact@v4
  with:
  name: linux-unpacked
  path: dist/linux-unpacked.zip
  - name: Zip Win Unpacked build
  run: zip -r dist/win-unpacked.zip dist/win-unpacked
  - name: Upload Win Unpacked build
- uses: actions/upload-artifact@v3
+ uses: actions/upload-artifact@v4
  with:
  name: win-unpacked
  path: dist/win-unpacked.zip
@@ -110,11 +115,6 @@ jobs:
  run: |
  brew install gnu-sed
  echo "$(brew --prefix)/opt/gnu-sed/libexec/gnubin" >> $GITHUB_PATH
- - name: Set repo owner
- run: |
- sed -i -e \
- "s/owner: '.*'/owner: '${{ github.repository_owner }}'/g" \
- "./electron-builder-config.js"
  - if: github.event.inputs.version != ''
  name: Set release version
  run: |
@@ -133,12 +133,19 @@ jobs:
  name: Use BFX API Staging for queries
  run: |
  echo "IS_BFX_API_STAGING=1" >> $GITHUB_ENV
- - uses: actions/setup-node@v3
+ - name: Set repository owner for auto-update
+ run: |
+ if [[ "${{ github.event.inputs.repoOwner }}" != "" ]]; then
+ echo "REPO_OWNER=${{ github.event.inputs.repoOwner }}" >> $GITHUB_ENV
+ else
+ echo "REPO_OWNER=${{ github.repository_owner }}" >> $GITHUB_ENV
+ fi
+ - uses: actions/setup-node@v4
  with:
  node-version: 18.17.1
  - name: Cache Electron binaries
  id: electron-cache
- uses: actions/cache@v3
+ uses: actions/cache@v4
  env:
  cache-name: electron-cache-v1
  with:
@@ -149,7 +156,7 @@ jobs:
  ${{ runner.os }}-build-${{ env.cache-name }}-
  - name: Build release
  id: release-builder
- uses: nick-fields/retry@v2
+ uses: nick-fields/retry@v3
  continue-on-error: false
  env:
  APPLE_TEAM_ID: ${{ secrets.BFX_APPLE_TEAM_ID }}
@@ -175,7 +182,7 @@ jobs:
  - name: Zip Mac Unpacked build
  run: zip -r dist/mac.zip dist/mac
  - name: Upload Mac Unpacked build
- uses: actions/upload-artifact@v3
+ uses: actions/upload-artifact@v4
  with:
  name: mac-unpacked
  path: dist/mac.zip
@@ -188,20 +195,20 @@ jobs:
  steps:
  - name: Checkout
  uses: actions/checkout@v4
- - uses: actions/setup-node@v3
+ - uses: actions/setup-node@v4
  with:
  node-version: 18.17.1
  - name: Install main dev deps
  run: npm i --development --no-audit --progress=false --force
  - name: Download Linux Unpacked build
- uses: actions/download-artifact@v3
+ uses: actions/download-artifact@v4
  with:
  name: linux-unpacked
  path: dist
  - name: Unzip Linux Unpacked build
  run: unzip dist/linux-unpacked.zip
  - name: Run tests
- uses: coactions/setup-xvfb@v1.0.1
+ uses: coactions/setup-xvfb@6b00cf1889f4e1d5a48635647013c0508128ee1a
  with:
  run: npm run e2e
  - name: Normalize E2E test report
@@ -220,20 +227,20 @@ jobs:
  steps:
  - name: Checkout
  uses: actions/checkout@v4
- - uses: actions/setup-node@v3
+ - uses: actions/setup-node@v4
  with:
  node-version: 18.17.1
  - name: Install main dev deps
  run: npm i --development --no-audit --progress=false --force
  - name: Download Linux Unpacked build
- uses: actions/download-artifact@v3
+ uses: actions/download-artifact@v4
  with:
  name: win-unpacked
  path: dist
  - name: Unzip Win Unpacked build
  run: 7z -y x dist/win-unpacked.zip
  - name: Run tests
- uses: coactions/setup-xvfb@v1.0.1
+ uses: coactions/setup-xvfb@6b00cf1889f4e1d5a48635647013c0508128ee1a
  with:
  run: npm run e2e
  - name: Normalize E2E test report
@@ -254,20 +261,20 @@ jobs:
  uses: actions/checkout@v4
  - name: Prepare Mac runner
  uses: ./.github/actions/prepare-mac-runner
- - uses: actions/setup-node@v3
+ - uses: actions/setup-node@v4
  with:
  node-version: 18.17.1
  - name: Install main dev deps
  run: npm i --development --no-audit --progress=false --force
  - name: Download Mac Unpacked build
- uses: actions/download-artifact@v3
+ uses: actions/download-artifact@v4
  with:
  name: mac-unpacked
  path: dist
  - name: Unzip Mac Unpacked build
  run: unzip dist/mac.zip
  - name: Run tests
- uses: coactions/setup-xvfb@v1.0.1
+ uses: coactions/setup-xvfb@6b00cf1889f4e1d5a48635647013c0508128ee1a
  with:
  run: npm run e2e
  - name: Normalize E2E test report

diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -18,7 +18,7 @@ jobs:
  uses: actions/checkout@v4
  with:
  submodules: recursive
- - uses: actions/setup-node@v3
+ - uses: actions/setup-node@v4
  with:
  node-version: 18.17.1
  - name: Setup configs and install deps

diff --git a/.github/workflows/e2e-test-report.yml b/.github/workflows/e2e-test-report.yml
@@ -16,6 +16,7 @@ jobs:
  e2e-web-page-report:
  name: E2E Web Page Report
  runs-on: ubuntu-22.04
+ if: ${{ github.event.workflow_run.conclusion == 'success' }}
  steps:
  - uses: dorny/test-reporter@v1
  id: linux-e2e-test-results

diff --git a/.github/workflows/test-report.yml b/.github/workflows/test-report.yml
@@ -16,6 +16,7 @@ jobs:
  web-page-report:
  name: Web Page Report
  runs-on: ubuntu-22.04
+ if: ${{ github.event.workflow_run.conclusion == 'success' }}
  steps:
  - uses: dorny/test-reporter@v1
  id: test-results

diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -7,6 +7,33 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+## [4.20.0] - 2024-03-06
+
+### Added
+
+- Added missing translations for `2FA`. PR: [bfx-report-ui#774](https://github.com/bitfinexcom/bfx-report-ui/pull/774)
+- Implemented exporting to PDF support for `Ledgers` and `Tax Reports`. PRs: [bfx-report#347](https://github.com/bitfinexcom/bfx-report/pull/347), [bfx-reports-framework#352](https://github.com/bitfinexcom/bfx-reports-framework/pull/352), [bfx-report-electron#319](https://github.com/bitfinexcom/bfx-report-electron/pull/319), [bfx-ext-pdf-js#4](https://github.com/bitfinexcom/bfx-ext-pdf-js/pull/4), [bfx-report#349](https://github.com/bitfinexcom/bfx-report/pull/349), [bfx-reports-framework#354](https://github.com/bitfinexcom/bfx-reports-framework/pull/354), [bfx-report-ui#775](https://github.com/bitfinexcom/bfx-report-ui/pull/775)
+- Added detection for `BFX` auth error: `ERR_AUTH_API: ERR_TOKEN_ALREADY_USED`. PR: [bfx-report#348](https://github.com/bitfinexcom/bfx-report/pull/348)
+- Added improvements to the token refresh flow: stop the auth token refresh interval if catch an auth error. PR: [bfx-reports-framework#353](https://github.com/bitfinexcom/bfx-reports-framework/pull/353)
+- Added option to set repo owner for auto-update in manual run. PR: [bfx-report-electron#331](https://github.com/bitfinexcom/bfx-report-electron/pull/331)
+
+### Changed
+
+- Reworked navigation for the `Movements` report according to the latest UX improvement proposals: remove tabs from wallets & movements, make movements a separate navigation item under `My History`. PR: [bfx-report-ui#771](https://github.com/bitfinexcom/bfx-report-ui/pull/771)
+- Reworked navigation for the `My History` section according to the latest UX improvement proposals. PR: [bfx-report-ui#778](https://github.com/bitfinexcom/bfx-report-ui/pull/778)
+- Enhanced `loading` and `no data` states representation for reports with tables. PR: [bfx-report-ui#779](https://github.com/bitfinexcom/bfx-report-ui/pull/779)
+- Set `90sec` timeout for grc requests to have the same timeout as for api requests. PR: [bfx-report#351](https://github.com/bitfinexcom/bfx-report/pull/351)
+- Set `90sec` timeout for `html-pdf` lib. PR: [bfx-reports-framework#355](https://github.com/bitfinexcom/bfx-reports-framework/pull/355)
+- Optimized GitHub Actions Workflow for release build. PR: [bfx-report-electron#322](https://github.com/bitfinexcom/bfx-report-electron/pull/322)
+- Updated Actions to use Nodejs `v20`. PR: [bfx-report-electron#323](https://github.com/bitfinexcom/bfx-report-electron/pull/323)
+
+### Fixed
+
+- Updated UI engines configuration to prevent issues. PR: [bfx-report-ui#772](https://github.com/bitfinexcom/bfx-report-ui/pull/772)
+- Fixed `2FA` authorization flow according to: After the first push of the auth button, we should lock the button (till we get any response from this endpoint) to prevent sending several of the same requests. PR: [bfx-report-ui#776](https://github.com/bitfinexcom/bfx-report-ui/pull/776)
+- Fixed the potential possibility of duplicated sending for correct `OTP`: it should keep btn disabled until the successful auth will be completed. PR: [bfx-report-ui#780](https://github.com/bitfinexcom/bfx-report-ui/pull/780)
+- Fixed 11 `auto-update-toast:width` listeners added. PR: [bfx-report-electron#330](https://github.com/bitfinexcom/bfx-report-electron/pull/330)
+
 ## [4.19.0] - 2024-02-14
 
 ### Added

diff --git a/Dockerfile.linux-builder b/Dockerfile.linux-builder
@@ -14,6 +14,7 @@ RUN ./scripts/helpers/install-nodejs.sh ${NODE_VERSION} \
  bc \
  && apt-get clean \
  && rm -rf /var/lib/apt/lists/*
+RUN chown root:root .
 
 COPY . .
 

diff --git a/Dockerfile.mac-builder b/Dockerfile.mac-builder
@@ -14,6 +14,7 @@ RUN ./scripts/helpers/install-nodejs.sh ${NODE_VERSION} \
  bc \
  && apt-get clean \
  && rm -rf /var/lib/apt/lists/*
+RUN chown root:root .
 
 COPY . .
 

diff --git a/Dockerfile.ui-builder b/Dockerfile.ui-builder
@@ -8,6 +8,7 @@ ENV IS_DEV_ENV=${IS_DEV_ENV:-0}
 COPY ./scripts/helpers/install-nodejs.sh ./scripts/helpers/install-nodejs.sh
 
 RUN ./scripts/helpers/install-nodejs.sh ${NODE_VERSION}
+RUN chown root:root .
 
 COPY . .
 

diff --git a/Dockerfile.win-builder b/Dockerfile.win-builder
@@ -17,6 +17,7 @@ RUN ./scripts/helpers/install-nodejs.sh ${NODE_VERSION} \
  bc \
  && apt-get clean \
  && rm -rf /var/lib/apt/lists/*
+RUN chown root:root .
 
 COPY . .
 

diff --git a/bfx-report-ui b/bfx-report-ui
diff --git a/bfx-reports-framework b/bfx-reports-framework
diff --git a/docker-compose.yaml b/docker-compose.yaml
@@ -28,6 +28,7 @@ services:
  IS_PUBLISHED: ${IS_PUBLISHED:-0}
  GH_TOKEN: ${GH_TOKEN:-}
  GITHUB_TOKEN: ${GITHUB_TOKEN:-}
+ REPO_OWNER: ${REPO_OWNER:-}
  EP_GH_IGNORE_TIME: ${EP_GH_IGNORE_TIME:-true}
  CURRENT_UID: ${CURRENT_UID:-"1000:1000"}
  volumes:
@@ -52,6 +53,7 @@ services:
  IS_PUBLISHED: ${IS_PUBLISHED:-0}
  GH_TOKEN: ${GH_TOKEN:-}
  GITHUB_TOKEN: ${GITHUB_TOKEN:-}
+ REPO_OWNER: ${REPO_OWNER:-}
  EP_GH_IGNORE_TIME: ${EP_GH_IGNORE_TIME:-true}
  CURRENT_UID: ${CURRENT_UID:-"1000:1000"}
  volumes:
@@ -76,6 +78,7 @@ services:
  IS_PUBLISHED: ${IS_PUBLISHED:-0}
  GH_TOKEN: ${GH_TOKEN:-}
  GITHUB_TOKEN: ${GITHUB_TOKEN:-}
+ REPO_OWNER: ${REPO_OWNER:-}
  EP_GH_IGNORE_TIME: ${EP_GH_IGNORE_TIME:-true}
  CURRENT_UID: ${CURRENT_UID:-"1000:1000"}
  volumes: