Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CPX] custom data types from gap8 to stm32 #121

Closed
wants to merge 1 commit into from

Conversation

matthewoots
Copy link

This PR addresses #116
A look at it is as shown below, using an example of sending apriltag detection of corners and pose estimation related data
cpx

crazyflie-firmware will need some tweaks, please use https://github.com/matthewoots/crazyflie-firmware/tree/cpx/receive_data and the commit is matthewoots/crazyflie-firmware@9fcb117

Adding @hmllr here too

…ta is serialized to cpx and sent from gap8 to stm32
@matthewoots
Copy link
Author

Linking crazyflie-firmware PR here bitcraze/crazyflie-firmware#1245

@ataffanel ataffanel requested review from evoggy and hmllr March 6, 2023 11:40
Copy link
Member

@ataffanel ataffanel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks quite good to me. Ideally we would have an actual API to send and receive APP packet without requiring the user to forge a CPX packet. But this example is good to show the current state of things. Let's wait for the STM32 PR bitcraze/crazyflie-firmware#1245 to be ready before merging this PR.

@ataffanel ataffanel requested review from ataffanel and removed request for evoggy and hmllr March 7, 2023 09:17
@matthewoots
Copy link
Author

matthewoots commented Mar 7, 2023

The way I handled this is to create a msg.h (or any other name) that handles serialization and deserialization, this can be copied and pasted into crazyflie-firmware and changing defines to omit the serialization portion (since 1. it does not run need to use the pmsis library and 2. does not need to send back the serialized message and 3. unused functions are not allowed), since the most would be that the user send back a response with a simple byte. Hopefully this helps explain to anyone who want to use it (I'll probably add in documentation next time). :))

@ataffanel, moving forward, I agree that there needs to be an API on this.

This looks quite good to me. Ideally we would have an actual API to send and receive APP packet without requiring the user to forge a CPX packet. But this example is good to show the current state of things. Let's wait for the STM32 PR bitcraze/crazyflie-firmware#1245 to be ready before merging this PR.

@matthewoots
Copy link
Author

I'll close this first and touch back on this when I have the time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants