Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(wallet)!: rename method to last_unused_address #1680

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Commits on Nov 19, 2024

  1. refactor(wallet)!: rename method to last_unused_address

    As per both out-of-band discussions, and the latest discussion at weekly
    development call, the semantics of this method can be misleading, as
    it's not guaranteed you get a next one on every call, that'd only happen
    if the address has been used and the application synced with latest
    blockchain state.
    
    Renaming it to `last_unused_address` gives it a better semantics, as
    you'll always get the last derived address which still unused. As per
    usage where the user needs always a new derived address on every call,
    you should still use the `reveal_next_address`, nothing changed.
    oleonardolima committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    07b85ca View commit details
    Browse the repository at this point in the history