-
Notifications
You must be signed in to change notification settings - Fork 311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: show example migration from bdk to bdk_wallet #1648
base: master
Are you sure you want to change the base?
Conversation
23a9d14
to
eb7328f
Compare
Looks good, simpler and safer than dealing directly with database or intermediate text files as I'd originally proposed. A few suggestions:
|
ffa2eef
to
dca8941
Compare
I tested this by first syncing a
and persisted with sqlite. Then I ran the example in this PR, initializing
I added assertions for utxos, balance, and revealed addresses. Just to note: this assumes the old database is up to date and no new information is presented as a result of syncing the new wallet. I'm wondering whether |
Yes I agree it might make a better book section with companion code to take snippets from. |
Maintenance version v0.30.0 of |
I created a migration workflow in the form of a runnable example that does everything in one go. In the example we
bdk_wallet::Wallet
with new database*UPDATED example code to use sqlite instead of sled, but it's waiting for a release with the changes from #1651
fixes #1606
Changelog notice
Checklists
All Submissions:
cargo fmt
andcargo clippy
before committing