removing the obsolete network parameter, and adding a test for the bu… #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rner output address
ulrichard
force-pushed
the
feature/burner
branch
from
7367bd8
to
082a300
Compare
notmandatory
approved these changes
Nov 21, 2024
There was a problem hiding this comment.
ACK 082a300
Sorry for the delay in looking at this. The teams been very focused on getting the 1.0.0 release wrapped up.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
removing the obsolete network parameter, and adding a test for the burner output address
we had some confusion with the address of the single output. The additional test serves also as documentation.