Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose add_global_xpubs() method on transaction builder #574

Merged
merged 1 commit into from
Aug 29, 2024
Merged

Expose add_global_xpubs() method on transaction builder #574

merged 1 commit into from
Aug 29, 2024

Conversation

thunderbiscuit
Copy link
Member

@thunderbiscuit thunderbiscuit commented Jul 23, 2024 •
edited
Loading

This PR exposes the add_global_xpubs() method on the TxBuilder. See the docs here.

Fixes #572

Changelog notice

Added
  - Add `add_global_xpubs()` method on `TxBuilder` [#574]

[#574]: https://github.com/bitcoindevkit/bdk-ffi/pull/574

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

New Features:

  • I've added tests for the new feature
  • I've added docs for the new feature

@thunderbiscuit
Copy link
Member Author

Wait for #575 before merging. A rebase on that will run all Python tests.

notmandatory
notmandatory approved these changes Jul 31, 2024
View reviewed changes
Copy link
Member

@notmandatory notmandatory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK effcab2

@thunderbiscuit thunderbiscuit merged commit 34a33d8 into bitcoindevkit:master Aug 29, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@notmandatory notmandatory notmandatory approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature: Expose add_global_xpubs
2 participants
@thunderbiscuit @notmandatory