Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: import descriptor+xpub #257

Merged
merged 9 commits into from
Nov 10, 2024
Merged

feat: import descriptor+xpub #257

merged 9 commits into from
Nov 10, 2024

Conversation

reez
Copy link
Collaborator

@reez reez commented Nov 9, 2024 •
edited
Loading

Description

#254

Notes to the reviewers

Changelog notice

Checklists

All Submissions:

New Features:

  • I've added tests for the new feature
  • I've added docs for the new feature
  • UI changes tested on small, medium, and large devices to ensure layout consistency

Bugfixes:

  • This pull request breaks the existing API
  • I've added tests to reproduce the issue which are now passing
  • I'm linking the issue being fixed by this PR

@reez reez linked an issue Nov 9, 2024 that may be closed by this pull request
Feature Request: Import Descriptors #254
Closed
@reez
Copy link
Collaborator Author

reez commented Nov 10, 2024

adding functionality for xpubs too now

@reez reez linked an issue Nov 10, 2024 that may be closed by this pull request
Feature Request: Import xpubs #255
Closed
@reez reez marked this pull request as ready for review November 10, 2024 22:01
@reez reez changed the title feat: import descriptor feat: import descriptor+xpub Nov 10, 2024
@reez reez merged commit 121b6bb into bitcoindevkit:main Nov 10, 2024
1 check passed
@reez reez deleted the import-desc branch November 10, 2024 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature Request: Import xpubs Feature Request: Import Descriptors
1 participant
@reez