Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Atomic to the wallets section #322

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add Atomic to the wallets section #322

wants to merge 2 commits into from

Conversation

centralizedtransformer
Copy link

Uploaded logo, Atomic added to desktop and android wallets.

@centralizedtransformer centralizedtransformer mentioned this pull request Apr 11, 2019
Closed
merc1er
merc1er suggested changes Nov 21, 2019
View reviewed changes
Copy link
Contributor

@merc1er merc1er left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Link redirects to Bitcoin (BTC) wallet instead of Bitcoin Cash.
Please fix this so I can approve and merge.

centralizedtransformer
centralizedtransformer commented Jan 15, 2020
View reviewed changes
Copy link
Author

@centralizedtransformer centralizedtransformer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Links updated
Thanks for reaching out! 👍

merc1er
merc1er suggested changes Feb 18, 2020
View reviewed changes
Copy link
Contributor

@merc1er merc1er left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After reviewing the wallet itself I found some major issues in the wallet (tested on iOS) such as:

  • Transaction takes a while to be detected
  • Default fee is 8 satoshi/byte
  • Sending "all" does not spend all UTXOs

@centralizedtransformer
Copy link
Author

centralizedtransformer commented Jun 23, 2022 •
edited
Loading

@richerandprettier @merc1er can you please re-check Atomic Wallet, we made a lot of changes to the app.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@merc1er merc1er merc1er requested changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
@Website
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@centralizedtransformer @merc1er