Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(build): handle autogen.sh failure on OpenBSD #1681

Draft
wants to merge 8 commits into
base: master
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/validation.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -396,7 +396,7 @@ jobs:
tput colors
date -u
run: |
sh -x ./test/test_nodebuilder --ref "${GITHUB_SHA}"
sh -x ./nodebuilder
[ "$?" -gt 0 ] && echo "test_nodebuilder exited with status $?" >&2 && exit 1
[ -f "/home/bitcoin/.bitcoin/debug.log" ] && cp "/home/bitcoin/.bitcoin/debug.log" .
find / -name debug.log 2> /dev/null | grep bitcoin || true
Expand Down
11 changes: 9 additions & 2 deletions nodebuilder
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@

set -o errexit
set -o nounset
set -x

check_dpkg_lock()
{
Expand Down Expand Up @@ -68,10 +69,16 @@ compile_bitcoin_from_source()
cd "${COMPILE_DIRECTORY}"/

log_info 'Analyzing hardware configuration.'
log_info 'DEBUG searching for autoreconf without sudo'
find / -name autoreconf 2> /dev/null
log_info 'DEBUG searching for autoreconf with sudo'
sudo find / -name autoreconf 2> /dev/null
# shellcheck disable=SC2230
command -v autoreconf > /dev/null 2>&1 ||
hash autoreconf > /dev/null 2>&1 ||
which autoreconf > /dev/null 2>&1 ||
throw_error "Build dependencies failed to install. Manually install 'autoconf' and try again."
./autogen.sh > /dev/null 2> "${STDERR_COMPILE_LOG_FILE}"
grep -v 'build-aux' "${STDERR_COMPILE_LOG_FILE}" >&2 || true
./autogen.sh

log_info 'Configuring the build environment.'
case "${TARGET_KERNEL}" in
Expand Down
Loading