Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ADHC-1001: Extra Contract and Version Bump #80

Open
wants to merge 35 commits into
base: trunk
Choose a base branch
from
Open

ADHC-1001: Extra Contract and Version Bump #80

wants to merge 35 commits into from

Conversation

vm06007
Copy link
Member

@vm06007 vm06007 commented Mar 16, 2024

  • adding version bump
  • adding VerseBalances.sol
  • adding LiquidityManager.sol

vm06007 added 30 commits May 18, 2023 02:03
@vm06007
add _makePath pure function
0454893
@vm06007
introduce MAX_VALUE
3f182c4
@vm06007
formatting for internal _callOptionalReturn
aacec9b
@vm06007
correct event property name typo
41db8f4
@vm06007
expand event LiquidityAdded with addedTo field
6f38653
@vm06007
temporary remove stakeLiquidity function
48bfcc0
@vm06007
remove unnecessary reads
e3f5abf
@vm06007
refactor namings
87114ea
@vm06007
improve tests
0ef4c47
@vm06007
description update, function name update
4624c57
@vm06007
add descriptions to functions
7219c47
@vm06007
expand LiquidityAdded event
c78c206
@vm06007
move event to _addLiquidity function
68b7e7e
@vm06007
adjust return values
eb97a05
@vm06007
add function descriptions
692f2fe
@vm06007
extra asserts in test added
646d9b0
@vm06007
cleanup unused items in test file
f0a3834
@vm06007
cleanup config
4e37fde
@vm06007
add extra tests
f4e04bf
@vm06007
new commands for coverage
2f9656e
@vm06007
update hardhat config
92b48be
@vm06007
add cleanUp function
4ed92db
@vm06007
convert internal to private
51938a6
@vm06007
remove unnecessary return and payable
434d86f
@vm06007
add extra description
cc66145
@vm06007
testing added
bb2d341
@vm06007
add extra properties to events
6a1dd63
@vm06007
formatting
16181a7
@vm06007
test asserts for event data
fd7172c
@vm06007
bump up version
36bb2f2 
- bump to =0.8.23
@vm06007 vm06007 requested a review from Mixelated March 16, 2024 17:54
This was referenced Apr 13, 2024
Open
Open
@bitcoin-portal bitcoin-portal deleted a comment from Awut789 Apr 22, 2024
@bitcoin-portal bitcoin-portal deleted a comment from Awut789 Apr 22, 2024
185805
185805 reviewed Oct 23, 2024
View reviewed changes
Copy link

@185805 185805 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@octocat This PR looks great - it's ready to merge!

185805
185805 reviewed Oct 23, 2024
View reviewed changes
Copy link

@185805 185805 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good
Uploading IMG_20241021_143517_426.jpg…

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@185805 185805 185805 left review comments

@Mixelated Mixelated Awaiting requested review from Mixelated

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vm06007 @185805