Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jade native psbt #753

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Jade native psbt #753

wants to merge 2 commits into from

Conversation

JamieDriver
Copy link
Contributor

  1. latest jade api to recognise more recently added hw
  2. remove code which walked psbt and mapped it into Jade's legacy 'sign_tx' json format - instead pass PSBT directly to Jade for signing, since this has been supported in fw now for well over a year and seems to be working well.

@JamieDriver JamieDriver changed the title Jade native psbt wip: Jade native psbt Sep 3, 2024
@JamieDriver JamieDriver force-pushed the jade_native_psbt branch 3 times, most recently from 2f4319e to cf73f8c Compare September 4, 2024 10:06
@JamieDriver JamieDriver changed the title wip: Jade native psbt Jade native psbt Sep 5, 2024
This was referenced Sep 5, 2024
Open
Open
Open
Open
@brunoerg
Copy link
Contributor

brunoerg commented Sep 5, 2024

Concept ACK

@JamieDriver
Copy link
Contributor Author

Thanks - any idea what's up with the CI ? Always feel more confident when CI looks good ...

@achow101
Copy link
Member

achow101 commented Sep 5, 2024

Thanks - any idea what's up with the CI ? Always feel more confident when CI looks good ...

You need to rebase.

@JamieDriver JamieDriver force-pushed the jade_native_psbt branch 4 times, most recently from c2e9632 to b8adf01 Compare September 10, 2024 11:23
@JamieDriver JamieDriver mentioned this pull request Sep 30, 2024
Open
@JamieDriver
jade: update Jade api to 1.0.31
afff850 
This extends the serial api to recognise recently supported hardware.
@JamieDriver
jade: use Jade's native PSBT signing and remove massaging into legacy…
c993e23 
… format
@JamieDriver JamieDriver mentioned this pull request Oct 11, 2024
Open
@JamieDriver
Copy link
Contributor Author

Probably best superseded by #763

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JamieDriver @brunoerg @achow101