BUGFIX: Game takes too long to process crime work with large number of cycles #1821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
catloversg
deleted the
pull-request/bugfix/game-takes-too-long-to-process-crime-work-with-large-number-of-cycles
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While making #1657, I suspected that generating CCT is not the only thing that blocks the game engine when the save file has too much bonus time. Now, when I check other mechanics, I find out that crime work also has this problem. This PR puts a cap on the number of processing cycles. Note that crime work of sleeves does not have this problem because we put a cap on sleeve's
cyclesUsedbefore callingthis.currentWork.process(this, cyclesUsed);.How to reproduce this bug:
Player.lastUpdateis 0 in that save file.Save file: test-crime-last-update-0.gz