Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wallets: Remove dependency to Bisq 2 FileUtils Class #2815

Conversation

alvasw
Copy link
Contributor

@alvasw alvasw commented Sep 11, 2024

We can't depend on Bisq 2's FileUtils class to be able to reuse the
wallets library in Bisq 1.

We can't depend on Bisq 2's Hex class to be able to reuse the wallets library in Bisq 1.
We can't depend on Bisq 2's Threading class to be able to reuse the wallets library in Bisq 1.
We can't depend on Bisq 2's NetworkUtils class to be able to reuse the wallets library in Bisq 1.
We can't depend on Bisq 2's StringUtils class to be able to reuse the wallets library in Bisq 1.
We can't depend on Bisq 2's FileUtils class to be able to reuse the
wallets library in Bisq 1.
Copy link
Contributor

@HenrikJannsen HenrikJannsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@HenrikJannsen HenrikJannsen merged commit 115adc1 into bisq-network:main Sep 12, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants