Use JRE instead of JDK Desktop Binary #2773
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HenrikJannsen
approved these changes
Sep 6, 2024
build-logic/packaging/src/main/kotlin/bisq/gradle/packaging/JLinkTask.kt
Outdated
Show resolved
Hide resolved
build-logic/packaging/src/main/kotlin/bisq/gradle/packaging/JLinkTask.kt
Outdated
Show resolved
Hide resolved
rodvar
force-pushed
the
feature/jre_from_jdk
branch
2 times, most recently
from
998601c
to
ea1e059
Compare
- generateInstallers depends on jlink task now - work out the list of mods needed for the app to function - optimize jlink command to trim as much unneded stuff as possible - adjust code for windows env - cleanup code, leave TODOs for future lines of improvement/optimization - gitignore vscode folder - added review suggestions
rodvar
force-pushed
the
feature/jre_from_jdk
branch
from
ea1e059
to
1b19302
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Approach
Use Gradle Java Toolchain--> Couldn't get it to pick up the JREDownload JRE manually and use it for runtime--> Too complicated, increase build timesResults
How to test this PR
$ ./gradlew apps:desktop:desktop-app-launcher:clean apps:desktop:desktop-app-launcher:generateInstallers --infoapps/desktop/desktop-app-launcher/buildfolder thecustom-jrefolder with the gerated skimmed JRE, and inpackages/jpackages/package/Bisq2...the installer corresponding to your env (e.g. Bisq2....dmg) . Install it and run the app. Also check the size of the binary. Please comment your results with details on your environment in this PR.Known Issues / Future lines of improvement
Dev Commit logs