Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Medium article scrapper #227

Closed
wants to merge 2 commits into from
Closed

Medium article scrapper #227

wants to merge 2 commits into from

Conversation

iamneelpatel
Copy link
Contributor

Medium article scrapper

The script will save the article content as a pdf.

Fixed #225

Checklist:

  • My code follows the style guidelines(Clean Code) of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have created a helpful and easy to understand README.md
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added screenshots(if any) that prove my fix is effective or that my feature works

Copy link
Owner

@bislara bislara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey, This is not exactly what I wanted. This is same as HTML to pdf conversion. We can have another issue for this. but This issue was specific for Medium Article Scrapper. You need to scrap the website and get everything from that.

Also, this PR is having files for website cloner as well.

@iamneelpatel
Copy link
Contributor Author

Yup makes sense. Can you make a issue for this kind of project. I can make a pr for that instead. And are you saying this script should be in the website cloner.

@bislara
Copy link
Owner

bislara commented Oct 27, 2020

Well, you can create an issue and work on that. You have my approval for this HTML to PDF project. Go ahead.

No I was saying that this PR had code for website cloner as well. Never mind. I will close this PR.
Also, Do you want to work on this issue as well? or should I unassign u?

@iamneelpatel
Copy link
Contributor Author

Let me work on the html to pdf conversion first, then i will work on this as i will have to look for a solution. You can unassign me for now.

@iamneelpatel
Copy link
Contributor Author

I will make a pr for pdf to html and can u assign that to me?

@bislara bislara closed this Oct 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Medium Article Scraper
2 participants