Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Cowbird's sync_permissions config which used invalid Magpie service types #336

Merged
merged 4 commits into from
Jul 4, 2023

Conversation

mishaschwartz
Copy link
Collaborator

Overview

In the cowbird config.yml.template file: the wps_outputs and weaver keys are supposed to be Magpie service types, not magpie service names. This causes all cowbird hooks to fail with:

cowbird.config.ConfigErrorInvalidServiceKey: Service `weaver` used in sync config is not valid since it was not found in Magpie services (['access', 'api', 'geoserver', 'geoserverwfs', 'geoserverwms', 'geoserverwps', 'ncwms', 'thredds', 'wfs', 'wps']).

This fix is already implemented in #323 but since that is waiting on Ouranosinc/cowbird#35 to get pulled in, this PR factors out the bugfix that isn't dependent on the cowbird PR.

This allows us to fix this configuration bug in the meantime

Changes

Non-breaking changes

None (bug fix)

Breaking changes

None

Related Issue / Discussion

Additional Information

@github-actions github-actions bot added component/cowbird Related to https://github.com/Ouranosinc/cowbird documentation Improvements or additions to documentation labels Jun 2, 2023
@crim-jenkins-bot
Copy link
Collaborator

E2E Test Results

DACCS-iac Pipeline Results

Build URL : http://daccs-jenkins.crim.ca:80/job/DACCS-iac-birdhouse/1602/
Result : failure

BIRDHOUSE_DEPLOY_BRANCH : cowbird-default-config-fix
DACCS_CONFIGS_BRANCH : master
PAVICS_E2E_WORKFLOW_TESTS_BRANCH : master
PAVICS_SDI_BRANCH : master

DESTROY_INFRA_ON_EXIT : true
PAVICS_HOST : https://host-140-35.rdext.crim.ca

Infrastructure deployment failed. Instance has not been destroyed. @matprov

@mishaschwartz mishaschwartz requested a review from tlvu June 2, 2023 17:32
@mishaschwartz mishaschwartz requested review from tlvu and removed request for tlvu June 13, 2023 18:09
@crim-jenkins-bot
Copy link
Collaborator

E2E Test Results

DACCS-iac Pipeline Results

Build URL : http://daccs-jenkins.crim.ca:80/job/DACCS-iac-birdhouse/1634/
Result : failure

BIRDHOUSE_DEPLOY_BRANCH : cowbird-default-config-fix
DACCS_CONFIGS_BRANCH : master
PAVICS_E2E_WORKFLOW_TESTS_BRANCH : master
PAVICS_SDI_BRANCH : master

DESTROY_INFRA_ON_EXIT : true
PAVICS_HOST : https://host-140-133.rdext.crim.ca

Infrastructure deployment failed. Instance has not been destroyed. @matprov

@matprov
Copy link
Collaborator

matprov commented Jun 13, 2023

run tests

@crim-jenkins-bot
Copy link
Collaborator

E2E Test Results

DACCS-iac Pipeline Results

Build URL : http://daccs-jenkins.crim.ca:80/job/DACCS-iac-birdhouse/1637/
Result : failure

BIRDHOUSE_DEPLOY_BRANCH : cowbird-default-config-fix
DACCS_CONFIGS_BRANCH : master
PAVICS_E2E_WORKFLOW_TESTS_BRANCH : master
PAVICS_SDI_BRANCH : master

DESTROY_INFRA_ON_EXIT : true
PAVICS_HOST : https://host-140-69.rdext.crim.ca

PAVICS-e2e-workflow-tests Pipeline Results

Tests URL : http://daccs-jenkins.crim.ca:80/job/PAVICS-e2e-workflow-tests/job/master/1178/

NOTEBOOK TEST RESULTS
    
[2023-06-13T20:47:53.112Z] ============================= test session starts ==============================
[2023-06-13T20:47:53.112Z] platform linux -- Python 3.9.16, pytest-7.3.1, pluggy-1.0.0
[2023-06-13T20:47:53.112Z] rootdir: /home/jenkins/agent/workspace/PAVICS-e2e-workflow-tests_master@2
[2023-06-13T20:47:53.112Z] plugins: anyio-3.6.1, dash-2.10.0, nbval-0.9.6, tornasync-0.6.0.post2, xdist-3.3.1
[2023-06-13T20:47:53.112Z] collected 245 items
[2023-06-13T20:47:53.112Z] 
[2023-06-13T20:48:02.648Z] notebooks-auth/test_thredds.ipynb ...........                            [  4%]
[2023-06-13T20:48:10.499Z] pavics-sdi-master/docs/source/notebooks/WCS_example.ipynb .......        [  7%]
[2023-06-13T20:48:21.280Z] pavics-sdi-master/docs/source/notebooks/WFS_example.ipynb ......         [  9%]
[2023-06-13T20:48:28.871Z] pavics-sdi-master/docs/source/notebooks/WMS_example.ipynb ........       [ 13%]
[2023-06-13T20:48:32.254Z] pavics-sdi-master/docs/source/notebooks/WPS_example.ipynb ..........     [ 17%]
[2023-06-13T20:56:39.116Z] pavics-sdi-master/docs/source/notebooks/climex.ipynb ............        [ 22%]
[2023-06-13T20:56:39.116Z] pavics-sdi-master/docs/source/notebooks/eccc-geoapi-climate-stations.ipynb . [ 22%]
[2023-06-13T20:56:46.524Z] ...............                                                          [ 28%]
[2023-06-13T20:56:55.914Z] pavics-sdi-master/docs/source/notebooks/eccc-geoapi-xclim.ipynb .....    [ 30%]
[2023-06-13T20:57:04.623Z] pavics-sdi-master/docs/source/notebooks/esgf-dap.ipynb .....F            [ 33%]
[2023-06-13T20:57:21.691Z] pavics-sdi-master/docs/source/notebooks/forecasts.ipynb ......           [ 35%]
[2023-06-13T20:57:23.079Z] pavics-sdi-master/docs/source/notebooks/jupyter_extensions.ipynb .       [ 35%]
[2023-06-13T20:57:27.874Z] pavics-sdi-master/docs/source/notebooks/opendap.ipynb .......            [ 38%]
[2023-06-13T20:57:32.828Z] pavics-sdi-master/docs/source/notebooks/pavics_thredds.ipynb .....       [ 40%]
[2023-06-13T21:00:30.208Z] pavics-sdi-master/docs/source/notebooks/regridding.ipynb ............... [ 46%]
[2023-06-13T21:01:50.794Z] .............                                                            [ 52%]
[2023-06-13T21:01:53.529Z] pavics-sdi-master/docs/source/notebooks/rendering.ipynb ....             [ 53%]
[2023-06-13T21:01:56.275Z] pavics-sdi-master/docs/source/notebooks/subset-user-input.ipynb ........ [ 57%]
[2023-06-13T21:02:21.932Z] .................                                                        [ 64%]
[2023-06-13T21:02:29.580Z] pavics-sdi-master/docs/source/notebooks/subsetting.ipynb .....           [ 66%]
[2023-06-13T21:02:30.960Z] pavics-sdi-master/docs/source/notebook-components/weaver_example.ipynb . [ 66%]
[2023-06-13T21:02:33.632Z] .FFFFFFFF                                                                [ 70%]
[2023-06-13T21:02:46.137Z] finch-master/docs/source/notebooks/dap_subset.ipynb ...........          [ 74%]
[2023-06-13T21:02:57.145Z] finch-master/docs/source/notebooks/finch-usage.ipynb ......              [ 77%]
[2023-06-13T21:02:59.059Z] PAVICS-landing-master/content/notebooks/climate_indicators/PAVICStutorial_ClimateDataAnalysis-1DataAccess.ipynb . [ 77%]
[2023-06-13T21:03:06.199Z] ......                                                                   [ 80%]
[2023-06-13T21:04:02.432Z] PAVICS-landing-master/content/notebooks/climate_indicators/PAVICStutorial_ClimateDataAnalysis-2Subsetting.ipynb . [ 80%]
[2023-06-13T21:04:49.167Z] .............                                                            [ 85%]
[2023-06-13T21:05:04.059Z] PAVICS-landing-master/content/notebooks/climate_indicators/PAVICStutorial_ClimateDataAnalysis-3Climate-Indicators.ipynb . [ 86%]
[2023-06-13T21:06:28.589Z] ....s.                                                                   [ 88%]
[2023-06-13T21:06:36.718Z] PAVICS-landing-master/content/notebooks/climate_indicators/PAVICStutorial_ClimateDataAnalysis-4Ensembles.ipynb . [ 88%]
[2023-06-13T21:06:52.227Z] ...                                                                      [ 90%]
[2023-06-13T21:07:04.450Z] PAVICS-landing-master/content/notebooks/climate_indicators/PAVICStutorial_ClimateDataAnalysis-5Visualization.ipynb . [ 90%]
[2023-06-13T21:07:29.952Z] ......                                                                   [ 93%]
[2023-06-13T21:07:32.972Z] notebooks/hummingbird.ipynb ............                                 [ 97%]
[2023-06-13T21:10:48.599Z] notebooks/stress-tests.ipynb .....                                       [100%]
[2023-06-13T21:10:48.599Z] 
[2023-06-13T21:10:48.599Z] =================================== FAILURES ===================================
    
  

@mishaschwartz
Copy link
Collaborator Author

@tlvu can I merge this one?

@github-actions github-actions bot added the ci/operations Continuous Integration components label Jul 4, 2023
@mishaschwartz mishaschwartz merged commit 0310106 into master Jul 4, 2023
3 checks passed
@mishaschwartz mishaschwartz deleted the cowbird-default-config-fix branch July 4, 2023 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/operations Continuous Integration components component/cowbird Related to https://github.com/Ouranosinc/cowbird documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants