Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Custom notebooks #150
Custom notebooks #150
Changes from 21 commits
3d4d9cf
8c8f715
1d5164f
85b50a0
e33f841
914bdc6
fc2e504
04b46a9
a3d5a24
27e5c7f
a91a145
a081a7c
f19af5e
51846fd
f8e2b12
55234f3
31d5027
fe7348c
cfe4634
5c1e56a
c934e3d
927f090
fe79bc5
8990073
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For these lines, I am aware it is not super clean. I haven't found an easier way to implement it yet, since the concerned variables have to be working both on shellscript and python.
About
DOCKER_NOTEBOOK_IMAGES
andJUPYTERHUB_IMAGE_SELECTION_NAMES
, we could have use those names in just one variable instead of 2, using a string "formatted similarly to a dictionary" such as"pavics;pavics/workflow-tests:210216 eo-crim;pavics/crim-jupyter-eo:0.1.0 ...."
but it would require additional string splitting, so I don't think it would be cleaner.Another thing is we could probably simplify this by using the same name all the time, instead of having 2 different name format. We would use the image name such as
pavics/crim-jupyter-eo:0.1.0
everywhere though, meaning it would be what we see in the jupyterhub list, and it would be the name of the directories for the tutorial-notebooks, instead of the shorter versioneo-crim
. I don't think it would be necessarily cleaner either. (Potential problem with the '/' found in the image names, clashing with using it as a directory name?)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed it's ugly, but also agree other alternative either complexify the implemenation a lot or look less great. Open to other alternative as well, if someone see something we both missed ...