fix: add MEDDRA id mapping for Disease semantic type #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 1043972245
💛 - Coveralls |
andrewsu
reviewed
Jul 19, 2021
| @@ -207,7 +207,8 @@ export const APIMETA: MetaDataItemsObject = { | |||
| GARD: ['mondo.xrefs.gard', 'disease_ontology.xrefs.gard'], | |||
| HP: ['mondo.xrefs.hp'], | |||
| SNOMEDCT: ['mondo.xrefs.sctid', 'umls.snomed.preferred', 'umls.snomed.non-preferred'], | |||
| NCIT: ['mondo.xrefs.ncit', 'disease_ontology.xrefs.ncit'] | |||
| NCIT: ['mondo.xrefs.ncit', 'disease_ontology.xrefs.ncit'], | |||
| MEDDRA: ['mondo.xrefs.meddra', 'disease_ontology.xrefs.meddra'], | |||
There was a problem hiding this comment.
will the trailing comma here cause any problems?
|
add a test for MEDDRA id @colleenXu |
|
I've put it in my to-do list as a non-urgent task. I'll contact later for guidance on how to write the test / where to put it |
|
Note that we have changed to using refactored ID resolver with SRI-based service (dev)... It's not clear if code like this is used anymore, or what kind of tests need to be done (discussions in biothings/biothings_explorer#283 and issues that I will create later) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses biothings/biothings_explorer#217
For BTE to use these operations and handle ID resolution correctly: NCATS-Tangerine/translator-api-registry#72