Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generalized stdout *clean version* #138

Draft
wants to merge 16 commits into
base: dev
Choose a base branch
from
Draft

Generalized stdout *clean version* #138

wants to merge 16 commits into from

Conversation

AlexPatrie
Copy link
Contributor

What new features does this PR implement?
Please summarize the features that this PR implements. As relevant, please indicate the issues that the PR closes.

  • Adds Optional default setting for StandardOutputCapturerLevel to Config object through a validation block.
  • Adjusted default setting from "c" to "python" (resolves dependency on capturer #135)
  • Adds type annotations to functions

What bugs does this PR fix?
Please summarize the bugs that this PR fixes. As relevant, please indicate the issues that the PR closes.

Fixes frozen stdout and no-output issues like biosimulators/Biosimulators_COPASI#56
How have you tested this PR?
Pytest, and self testing.

@AlexPatrie AlexPatrie requested a review from eagmon May 10, 2023 19:51
@AlexPatrie AlexPatrie removed the request for review from eagmon May 11, 2023 15:37
@sonarcloud
Copy link

sonarcloud bot commented May 11, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 7 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

dependency on capturer
1 participant